Skip to content

feat: scope localStorage per visitor for Cloudflare Pages demo#187

Open
evanoseen wants to merge 1 commit into
mainfrom
186-deploy-a-public-live-demo-to-cloudflare-pages
Open

feat: scope localStorage per visitor for Cloudflare Pages demo#187
evanoseen wants to merge 1 commit into
mainfrom
186-deploy-a-public-live-demo-to-cloudflare-pages

Conversation

@evanoseen

Copy link
Copy Markdown
Collaborator

Closes #186

Live demo deployed at https://csf-profile.pages.dev

Changes:

  • Scoped localStorage keys per visitor using a random ID to prevent cross-contamination between demo users
  • Added _redirects file for Cloudflare Pages SPA routing
  • Added live demo link to README

@evanoseen evanoseen linked an issue Apr 28, 2026 that may be closed by this pull request
4 tasks
@CPAtoCybersecurity

Copy link
Copy Markdown
Owner

Hey @evanoseen, please resolve the conflicts on this one when you get a chance. Branch is 8 commits behind main, and the 3 conflicting store files (artifactStore.js, assessmentsStore.js, findingsStore.js) had additive changes land on main after this branch was cut — in each, we want both sides: your scopedKey wrap and the new state/methods on main.

git fetch origin
git checkout 186-deploy-a-public-live-demo-to-cloudflare-pages
git rebase origin/main
# resolve each file → git add <file> → git rebase --continue
git push --force-with-lease

Use --force-with-lease, not plain --force. After the rebase, build locally and confirm the demo still works. If any conflict looks ambiguous, drop a comment here before committing — happy to walk through it. Let's land this one before #193.

@evanoseen

Copy link
Copy Markdown
Collaborator Author

Rebase is done and conflicts are resolved (scopedKey wrap kept, version numbers from main kept — v6/v9/v4). Force-push is blocked by a branch protection rule on this branch. Can you temporarily allow force-push to 186-deploy-a-public-live-demo-to-cloudflare-pages so I can push the rebased commits?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Deploy a public live demo to Cloudflare Pages

2 participants