(1.21.1) Vertical slab model orientation #320
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, we were generating all the vertical slab models by rotating the bottom slab model, which made certain vertical double slabs look strange. I've switched it to using the top slab model for the positive half and the bottom slab model for the negative half.
Before:
After:
This rotation method still leaves us with weird-looking differences between how vertical slabs behave as opposed to normal slabs & stairs, so we should probably switch to attempting to load a dedicated vertical slab model and then falling back to the rotated horizontal slab model (so one could fix that with a resource pack), but I don't know how to do that so I'm leaving it here for now.