Fixed with_sealed_socket UAF issue - #106
Open
nding0405 wants to merge 2 commits into
Open
Conversation
nding0405
force-pushed
the
fix-with-sealed-socket-UAF
branch
2 times, most recently
from
July 22, 2026 23:27
ab2c27f to
cf29fd7
Compare
Comment on lines
+121
to
+128
| Timeout unlimited{UnlimitedTimeout}; | ||
| /** | ||
| * We are not holding the socket lock here, but still doing | ||
| * deference of the socket, which can lead to an UAF error. | ||
| * To address this, we use ephemeral call before dereferencing | ||
| * the socket. | ||
| */ | ||
| int result = heap_claim_ephemeral(&unlimited, socket, nullptr); |
Contributor
There was a problem hiding this comment.
The idiomatic way of writing this is:
int result = heap_claim_ephemeral(TimeoutWaitForever, socket, nullptr);That said, I'm not entirely comfortable having a thing with an unlimited timeout inside APIs that all take a timeout. We should be propagating that down.
Contributor
Author
There was a problem hiding this comment.
Shall we change the signature of the lockless with_sealed_socket? It currently doesn't take the timeout argument.
nding0405
force-pushed
the
fix-with-sealed-socket-UAF
branch
from
July 31, 2026 01:35
cf29fd7 to
5967def
Compare
Currently, in the lockless with_sealed_socket, we dereference the socket to read epoch while not holding the socket lock. That will lead to UAF bug and trigger network stack crash when another thread frees the socket. To address this, heap_claim_ephemeral has been added right before dereferencing the socket. It will return -EINVAL if the socket is freed by some other threads.
nding0405
force-pushed
the
fix-with-sealed-socket-UAF
branch
from
August 9, 2026 00:38
86ef274 to
e106ebd
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR partially addresses issue #104. It adds an ephemeral claim in
with_sealed_socket()to prevent a Use-After-Free when the socket is dereferenced before acquiring its lock. The remaining case mentioned in #104 that needs to be fixed is innetwork_socket_close(), where we need another ephemeral claim to prevent a Use-After-Free if the lock has already been destroyed during a reset.