Open
Conversation
lrineau
requested changes
May 5, 2026
Member
lrineau
left a comment
lrineau
left a comment
There was a problem hiding this comment.
I know this is a work-in-progress. I have a few suggestions anyway.
Comment on lines
+3288
to
+3290
| operator()(const typename K::Ray_3& ray, | ||
| const typename K::Point_3& query, | ||
| const K& k) |
Member
There was a problem hiding this comment.
Please do not change the indentation. It was correct.
Suggested change
| operator()(const typename K::Ray_3& ray, | |
| const typename K::Point_3& query, | |
| const K& k) | |
| operator()(const typename K::Ray_3& ray, | |
| const typename K::Point_3& query, | |
| const K& k) |
Comment on lines
+3300
to
+3304
| typename K::Point_3 | ||
| operator()(const typename K::Sphere_3& sphere, | ||
| const typename K::Point_3& query, | ||
| const K& k) | ||
| { |
Member
There was a problem hiding this comment.
Suggested change
| typename K::Point_3 | |
| operator()(const typename K::Sphere_3& sphere, | |
| const typename K::Point_3& query, | |
| const K& k) | |
| { | |
| typename K::Point_3 | |
| operator()(const typename K::Sphere_3& sphere, | |
| const typename K::Point_3& query, | |
| const K& k) | |
| { |
Comment on lines
+3305
to
+3312
| typename K::Construct_point_3 point = k.construct_point_3_object(); | ||
| typename K::Compute_x_3 x = k.compute_x_3_object(); | ||
| typename K::Compute_y_3 y = k.compute_y_3_object(); | ||
| typename K::Compute_z_3 z = k.compute_z_3_object(); | ||
| typename K::Construct_vector_3 vector = k.construct_vector_3_object(); | ||
| typename K::Construct_center_3 center = k.construct_center_3_object(); | ||
| typename K::Compute_squared_radius_3 squared_radius = k.compute_squared_radius_3_object(); | ||
| typename K::Compute_squared_length_3 squared_length = k.compute_squared_length_3_object(); |
Member
There was a problem hiding this comment.
Just a note: you can use auto instead of typing all those types.
Comment on lines
+3323
to
+3324
| if (sq_len < sq_rad) | ||
| return query; |
Member
There was a problem hiding this comment.
So, if the query is inside the sphere, it stays where it is? Does this mean the project of query to the sphere is actually a projection to the ball?
Comment on lines
+3328
to
+3330
| if (sq_len == 0) { | ||
| return point(x(c), y(c), z(c) + rad); | ||
| } |
Member
There was a problem hiding this comment.
Before there was already
if (sq_rad == 0) return c;if (sq_len < sq_rad) return query;
so I think sq_len == 0 is not possible. Can we assume that squared_radius(sphere)>=0?
Comment on lines
+3331
to
+3332
| const typename K::FT len = CGAL::sqrt(sq_len); | ||
| const typename K::FT f = rad / len; |
Member
There was a problem hiding this comment.
In generate I do no really like short names, especially when the longer names are already short:
Suggested change
| const typename K::FT len = CGAL::sqrt(sq_len); | |
| const typename K::FT f = rad / len; | |
| const typename K::FT length = CGAL::sqrt(sq_len); | |
| const typename K::FT fraction = radius / length; |
| const typename K::FT len = CGAL::sqrt(sq_len); | ||
| const typename K::FT f = rad / len; | ||
|
|
||
| return point(x(c) + f * x(v), y(c) + f * y(v), z(c) + f * z(v)); |
Member
There was a problem hiding this comment.
You should not use the x/y/z coordinates. Use higher-level constructions from the kernel:
Suggested change
| return point(x(c) + f * x(v), y(c) + f * y(v), z(c) + f * z(v)); | |
| auto scaled_vector = k.construct_scaled_vector_3_object(); | |
| auto translated_vector = l.construct_translated_vector_3_object(); | |
| return translated_vector(center, scaled_vector(v, factor)); |
lrineau
added
the
Not yet approved
| @@ -0,0 +1,99 @@ | |||
| // Copyright (c) 2012 INRIA Sophia-Antipolis (France). | |||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary of Changes
Adding a primitive type allowing to create an AABBtree of Sphere_3.
Release Management