Nef_S2: Skip running assertion code when runtime assertions are disabled

[GilesBathgate]

Summary of Changes

Since CGAL_assertion_code ignores the state of CGAL::get_use_assertions() some assertion code in SM_const_decorator.h gets unnecessarily run. The only sensible thing to me seems to be to add some additional CGAL_assertion_code to skip everything when runtime assertions are disabled.

Release Management

• Affected package(s): Nef_3/Nef_S2
• Issue(s) solved (if any): performance/bugfix
• License and copyright ownership: CGAL authors

[GilesBathgate]

@afabri I also request for your comment regarding: 9b357c6#r97801479

[afabri]

In case it only concerns check_integrity_and_topological_planarity(bool faces) would it not make sense to put that one in a CGAL_assertion(..)` and to replace the assertions in the function itself?

[GilesBathgate]

would it not make sense to put that one in a CGAL_assertion(..)` and to replace the assertions in the function itself?

That would be an appropriate alternative. I also did it this way for brevity, and to keep the code active when CGAL_NEF_TRACEN/CGAL_USE_TRACE is active.

[afabri]

This PR is also the right moment to fix this warning concerning this line (as well as line 310) where we have to put CGAL_assertion_code() around.

[GilesBathgate]

This PR is also the right moment to fix this warning concerning this line (as well as line 310) where we have to put CGAL_assertion_code() around.

Fixed in #7260