Nef_3: SNC_structure cleanup - easier debugging#6462
Closed
GilesBathgate wants to merge 4 commits intoCGAL:mainfrom
Closed
Nef_3: SNC_structure cleanup - easier debugging#6462GilesBathgate wants to merge 4 commits intoCGAL:mainfrom
GilesBathgate wants to merge 4 commits intoCGAL:mainfrom
Conversation
c7f7c9c to
3166976
Compare
3166976 to
f81f8a9
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary of Changes
In SNC_structure there is a pattern for creating 'nodes'
vertices_.push_back(* get_vertex_node(Vertex()));This is confusing when compiled in debug mode because without optimisations the
Vertex()gets initialised in the callee but it's just used as a 'tag' parameter, and the allocator in theget_vertex_nodefunction creates the real instance. All of theget_x_nodefunctions essentially do the same thing using a different allocator, so they can be simplified to a single template function. The same can be done for theput_x_nodefunctions. Replacing these reduces the amount of 'boilerplate' code.Release Management