Skip to content

Nef_3: SNC_structure cleanup - easier debugging#6462

Closed
GilesBathgate wants to merge 4 commits intoCGAL:mainfrom
GilesBathgate:Nef_3-cleanup_snc_structure-GilesBathgate
Closed

Nef_3: SNC_structure cleanup - easier debugging#6462
GilesBathgate wants to merge 4 commits intoCGAL:mainfrom
GilesBathgate:Nef_3-cleanup_snc_structure-GilesBathgate

Conversation

@GilesBathgate
Copy link
Copy Markdown
Contributor

Summary of Changes

In SNC_structure there is a pattern for creating 'nodes'

vertices_.push_back(* get_vertex_node(Vertex()));

This is confusing when compiled in debug mode because without optimisations the Vertex() gets initialised in the callee but it's just used as a 'tag' parameter, and the allocator in the get_vertex_node function creates the real instance. All of the get_x_node functions essentially do the same thing using a different allocator, so they can be simplified to a single template function. The same can be done for the put_x_node functions. Replacing these reduces the amount of 'boilerplate' code.

Release Management

  • Affected package(s): Nef_3
  • Issue(s) solved (if any): cleaning / easier debugging
  • License and copyright ownership: Returned to CGAL authors

@GilesBathgate GilesBathgate force-pushed the Nef_3-cleanup_snc_structure-GilesBathgate branch 2 times, most recently from c7f7c9c to 3166976 Compare January 18, 2023 08:28
@GilesBathgate GilesBathgate force-pushed the Nef_3-cleanup_snc_structure-GilesBathgate branch from 3166976 to f81f8a9 Compare January 18, 2023 08:35
@sloriot sloriot changed the base branch from master to main September 16, 2025 19:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant