Open
Conversation
Cyl18
reviewed
Nov 27, 2025
Cyl18
reviewed
Nov 27, 2025
There was a problem hiding this comment.
Pull request overview
This PR adds a download progress window for the I18n mod, providing users with visual feedback during resource pack download and installation operations.
Key changes:
- Introduces a Swing-based GUI window (
LoadDetailUI) that displays download progress, logs, and allows users to cancel operations - Implements stage tracking through the
LoadStageenum to monitor progress through initialization, download, conversion, and application phases - Integrates logging throughout the download workflow to keep users informed
Reviewed changes
Copilot reviewed 6 out of 9 changed files in this pull request and generated 14 comments.
Show a summary per file
| File | Description |
|---|---|
| src/main/java/i18nupdatemod/core/LoadDetailUI.java | New Swing GUI window for displaying download progress with progress bar, log area, and cancel functionality |
| src/main/java/i18nupdatemod/entity/LoadStage.java | New enum defining five stages of the loading process with descriptions |
| src/main/java/i18nupdatemod/I18nUpdateMod.java | Integrated LoadDetailUI display and shutdown checks at key points in the init workflow |
| src/main/java/i18nupdatemod/core/I18nConfig.java | Added log messages when fetching mirror sources |
| src/main/java/i18nupdatemod/core/ResourcePack.java | Added log messages for download status and completion |
| src/main/java/i18nupdatemod/core/ResourcePackConverter.java | Added log message during resource pack conversion |
| build.gradle.kts | Modified resource processing to handle JSON files separately from mod.json files |
| src/main/resources/icons/CFPA.png | New icon resource for the window |
| src/main/resources/icons/CFPA_with_title.png | New icon resource with title |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
AI is so great Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
|
feat: 出现错误时由手动关闭改为5s后自动关闭 或者5s后自动重试，同时显示停止按钮避免一直循环。 |
Contributor
Author
自动关闭做好了，个人体感5s略短，改成了6秒。异步重试我想想 |
|
是我的问题吗，拉到本地看了一下并没有出现gui |
|
该 feat 在 1.21.1 neoforge 确认可以生效 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.