Fix observer render attempt past childless sides#137
Open
arbruijn wants to merge 1 commit intoCDarrow:masterfrom
Open
Fix observer render attempt past childless sides#137arbruijn wants to merge 1 commit intoCDarrow:masterfrom
arbruijn wants to merge 1 commit intoCDarrow:masterfrom
Conversation
Collaborator
|
My understanding of C is entry level, but I will ask this anyway. :) Is this check happening in the right spot?
If |
Contributor
Author
|
That's right, but |
Collaborator
|
Huh. Those are really weird statements that define window_check and some others... But that's neither here nor there, I would definitely add the check just in case someone somewhere down the line wants window_check to be 0. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.