Map project tag array down to array of plain strings #169#225
Open
Obi-Wan-Pierogi wants to merge 1 commit intoCCAppDevs:developmentfrom
Open
Map project tag array down to array of plain strings #169#225Obi-Wan-Pierogi wants to merge 1 commit intoCCAppDevs:developmentfrom
Obi-Wan-Pierogi wants to merge 1 commit intoCCAppDevs:developmentfrom
Conversation
Adds a read-only property to Asset interface that returns tag names as strings. Creates utility functions for processing assets with tag name getters. Updates DataService to process assets with tag names. Updates Project Page component to use assetTagNames property for filtering.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Asset Tag Names Feature
This adds a read-only assetTagNames property to the Asset interface that automatically extracts tag names from the asset's tags collection. This makes it easier to display and filter assets by their tags.
Changes Made:
Modified asset.ts to include a read-only assetTagNames property
Created new asset-utils.ts file with utility functions for processing assets
Updated data.service.ts to process assets with tag name getters
Enhanced the Project Page component with tag filtering capability
Implementation Details:
The assetTagNames property is implemented as a getter that extracts tag names from assetTags
All asset processing happens when data is received from the API
Made sure empty assets handle the property correctly
Added tag filtering to allow users to filter assets within a project