Conversation
pihltd
approved these changes
May 8, 2026
pihltd
left a comment
pihltd
left a comment
There was a problem hiding this comment.
Minor change to provide CDE ID looks fine.
pihltd
approved these changes
May 8, 2026
This was referenced May 8, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds the study_accession property to the ICDC data model and finalizes the caDSR code mapping for consent_group_id.
Changes
model-desc/icdc-model-props.yml
Added new property study_accession — dbGaP study accession number (optional, pattern ^phs[0-9]+$), mapped to caDSR DSS CDE code 11524544 (Research Activity dbGaP Accession Number Identifier, v1.00).
Replaced placeholder Code: 'TBD' on consent_group_id with the assigned caDSR code 16306756 (Study Consent Group Identifier).
model-desc/icdc-model.yml
Added study_accession to the property list of the study node.
Why
Captures the dbGaP study accession identifier on the study node and replaces the temporary TBD code on consent_group_id with the now-assigned caDSR identifier, completing terminology binding for that property.