Skip to content

3.2.0 multi s3 folders#129

Merged
n2iw merged 11 commits into
3.2.0from
3.2.0_multi_batch
Apr 20, 2026
Merged

3.2.0 multi s3 folders#129
n2iw merged 11 commits into
3.2.0from
3.2.0_multi_batch

Conversation

@wfy1997
Copy link
Copy Markdown
Contributor

@wfy1997 wfy1997 commented Apr 13, 2026

No description provided.

@wfy1997 wfy1997 requested a review from n2iw April 13, 2026 14:00
Comment thread loader.py Outdated
Comment on lines +128 to +129

if not os.path.exists(config.dataset[0]):
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Need to process all items in the list, not only the first one.

wfy1997 added 8 commits April 15, 2026 15:43
This reverts commit 980f5bc.
This reverts commit 0b8632e.
add a random uuid to the local folder name to make sure the local folder names are unique if the different s3 folders have the same last subfolders names
Copy link
Copy Markdown

@n2iw n2iw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@n2iw n2iw merged commit af5063f into 3.2.0 Apr 20, 2026
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants