3.2.0 multi batch loading and load empty cell as null update#128
Merged
Conversation
n2iw
requested changes
Mar 27, 2026
| if not config.s3_folder and not os.path.isdir(config.dataset): | ||
| dataset = config.dataset | ||
| if isinstance(config.dataset, list): | ||
| dataset = config.dataset[0] |
There was a problem hiding this comment.
Shouldn't we check all config.dataset list, instead of just the first one?
| sys.exit(1) | ||
| if not list_dataset: | ||
| prop_path = os.path.join(config.dataset, config.prop_file) | ||
| if os.path.isfile(prop_path): |
There was a problem hiding this comment.
The purpose of this part of code is to allow a prop file inside dataset folder to overwrite default prop file, so we should always check if there is a prop file inside dataset folder, no matter there is a single dataset or multiple.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.