Skip to content

Added new validations for CBIO #221

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
cawohnjing merged 2 commits into from
Oct 6, 2025
Merged

Added new validations for CBIO #221

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a015777
Added new validations for CBIO
cawohnjing Oct 1, 2025
3bf7487
Fixed the frontend cbio monitoring
cawohnjing Oct 2, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
24 changes: 22 additions & 2 deletions monitoring/FNL-Monitoring-List.csv
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -738,6 +738,26 @@ $http.post('https://populationsciences-qa.datacommons.cancer.gov/v1/graphql/',

}
);",,TRUE,C07E28M8R7T,,
cBioPortal for Cancer Genomics,cbioportal,CCDI,Dev,Portal,https://cbioportal-dev.ccdi.cancer.gov,,,TRUE,B0920R3SETE,,
cBioPortal for Cancer Genomics,cbioportal,CCDI,Dev,Portal,https://cbioportal-dev.ccdi.cancer.gov,,cBioPortal,TRUE,B0920R3SETE,,
cBioPortal for Cancer Genomics,cbioportal,CCDI,Dev,Content,https://cbioportal-dev-content.ccdi.cancer.gov,,,TRUE,B0920R3SETE,,
cBioPortal for Cancer Genomics,cbioportal,CCDI,Dev,API,https://cbioportal-api-dev.ccdi.cancer.gov,,,TRUE,B0920R3SETE,,
cBioPortal for Cancer Genomics,cbioportal,CCDI,Dev,API,https://cbioportal-api-dev.ccdi.cancer.gov,"var assert = require('assert');

$http.get('https://cbioportal-api-dev.ccdi.cancer.gov/api/cancer-types',

function (err, response, body) {

if (err) {
throw new Error(err);
}

console.log('Response:', body);
console.log('Response:', response.statusCode);

assert.equal(response.statusCode, 200, 'Expected a 200 OK response.');
assert.ok(Array.isArray(body), 'Expected response body to be an array.');

Copy link

Copilot AI Oct 2, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Accessing body[0] without checking if the array is empty will throw an error if the API returns an empty array. Add a length check before accessing the first element.

Suggested change
assert.ok(body.length > 0, 'Expected response array to have at least one element.');

Copilot uses AI. Check for mistakes.
const firstObj = body[0]
Comment on lines +757 to +759
Copy link

Copilot AI Oct 2, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The body response from an HTTP request is typically a string that needs to be parsed as JSON before checking if it's an array. The Array.isArray(body) check will always fail for string responses.

Suggested change
assert.ok(Array.isArray(body), 'Expected response body to be an array.');
const firstObj = body[0]
let parsedBody;
try {
parsedBody = JSON.parse(body);
} catch (e) {
throw new Error('Failed to parse response body as JSON: ' + e.message);
}
assert.ok(Array.isArray(parsedBody), 'Expected response body to be an array.');
const firstObj = parsedBody[0]

Copilot uses AI. Check for mistakes.
assert.ok('cancerTypeId' in firstObj, 'Expected object to have cancerTypeId key')

}
);",,TRUE,B0920R3SETE,,
Loading