Skip to content

Conversation

@nimrof
Copy link
Collaborator

@nimrof nimrof commented Nov 21, 2025

Sorry for the delay.
Profile import is now ready for testing.

Recording.2025-11-21.185541.mp4

In addition to the new function I added some tests in ProfileImportTests.cs that runs tests against a simulated gui. Hoping it can be used more in the future to reduce bugs in the gui

There are hopefully only a few things that differs from the original:

  • The offset will react on key-press, not on enter-press
    On my 5year old cpu it felt very snappy and I did not notice any problems with the extra work
  • When you try to insert multiple offsets and there the same index is used in two (or more) the first use (on the left) will not be market as a collision and will be imported. You can see it in the clip where the first offset is white and the rest has mostly red.
    Will be happy to change back if you disagree, but I think it makes it a little clearer.

@nimrof nimrof self-assigned this Nov 21, 2025
@CANopenNode
Copy link
Owner

Greetings from Ubuntu:
Gui2 + VS Code

@CANopenNode
Copy link
Owner

I'm still a little short for full review, but looks great so far.

Just no problem on Linux, installed dotnet-sdk-8.0, cd to EDSEditorGUI2 source code and dotnet run. VS Code also shows preview of the GUI with the Avalonia extension.

Copy link
Collaborator

@trojanobelix trojanobelix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great so far. Tested under Visual Studio 2026.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants