extend arithmetic functions to support differential quantities#127
Open
rjnrohit wants to merge 1 commit intoBoostGSoC19:developfrom
Open
extend arithmetic functions to support differential quantities#127rjnrohit wants to merge 1 commit intoBoostGSoC19:developfrom
rjnrohit wants to merge 1 commit intoBoostGSoC19:developfrom
Conversation
rjnrohit
changed the title
This was referenced Apr 14, 2020
Author
|
@sarthak2007 I have created a separate PR as you suggested. you may wanna review it one more time. |
sarthak2007
requested changes
Apr 14, 2020
Author
|
@sarthak2007 I have changed what you had requested. Now there is no conflict of differential argument get passed through make_cartesian_representation. Please have a look at the changes. |
sarthak2007
requested changes
Apr 22, 2020
Author
|
@sarthak2007 changes done! as you have suggested.@lpranam, please see this PR and provide your suggestions. |
sarthak2007
approved these changes
Apr 27, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
References
Fixes #125