feat : onboarding view #111
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
generalban
requested review from
NeoSelf1,
ericKwon95 and
tjdrb3807
and removed request for
NeoSelf1
ericKwon95
requested changes
Feb 25, 2025
Contributor
ericKwon95
left a comment
ericKwon95
left a comment
There was a problem hiding this comment.
고생 많으셨습니다!
온보딩 완료 후 나의책장 -> 메인으로 이동하는 버그, 탭바가 선택되지 않은 버그가 있어 Request changes로 설정하였습니당
이 부분은 나중에 고쳐도 무방할 것 같아요~!
@seongto
온보딩 폰트가 아래와 같이 나오는데, 혹시 의도하신 바인지 궁금합니다!
|
|
||
| @main | ||
| class AppDelegate: UIResponder, UIApplicationDelegate { | ||
| // MARK: - Properties |
Contributor
There was a problem hiding this comment.
SceneDelegate에서 앱 플로우가 시작되었던 것으로 기억하고 있습니다만, 이 코드가 AppDelegate에 작성되어 있는 경우가 궁금합니다~!
| window = UIWindow(windowScene: windowScene) | ||
|
|
||
| // 개발 중 온보딩 화면을 항상 표시하려면 아래 줄을 활성화 | ||
| UserDefaults.standard.removeObject(forKey: "isOnboardingCompleted") |
|
|
||
| var onFinish: (() -> Void)? | ||
|
|
||
| private let scrollView = UIScrollView() |
Contributor
There was a problem hiding this comment.
수직 스크롤은 비활성화해야 할 것 같아요!
Contributor
There was a problem hiding this comment.
디자인에서도 스크롤을 없도록 애니메이션도 만들었던 거라 아마 필요없을 꺼라 생각합니다.
| // MARK: - Functions | ||
|
|
||
| func loadTutorials() { | ||
| // JSON 파일 이름과 타이틀 설정 |
Contributor
There was a problem hiding this comment.
요 코드 디자인시스템에 관련해서 정의하기 적절한 영역이 있었던 것으로 기억해요!
LottieLocalView - LottieAnimationName 살펴보시면 좋을 듯 합니당
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
✅ 작업 사항
온보딩 화면 구현
Lottie 애니메이션을 활용한 튜토리얼 화면 추가
"다음" 버튼 클릭 시 페이지 이동 및 온보딩 완료 처리
원형 인디케이터 (페이지 컨트롤) 추가 및 현재 페이지 표시
DesignSystem의 Colors.brandSub, Colors.brandSub2 색상 적용