Retry initialize if it fails#292
Open
assensamuelsson wants to merge 1 commit intoBonnierNews:mainfrom
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Retry initialize if it failed to check out a valid project id.
I've seen several times in my service that we can't fetch the project id from the metadata server fast enough meaning many of our logs will not be properly annotated. In this case I think it makes sense to retry the initialize.
We could instead increase the timeout but it will never be completely robust in case of latency issues.
I'm aware that this causes a
fetchrequest every time when developing locally. Should we expose a config for this somehow or make it clear in docs that it is a good idea to set the env varGCP_PROJECTwhen running locally?