Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR has to wait for PR #39 to be merged, as it includes it. The diff will be easier to read once that one reaches the
test
branch.@zsigmas See if you like the approach. I basically inject an extra div to the right of the bulk review menu, in the top container and populate it through the
initComplete
DT callback. There's some gratuitous reshaping of code that I hope you don't mind.@yash See if you like the result. The title consists of the label associated to the dataset inside an
h4
HTML heading. If the label is not available, we fall back to the dataset name. Right now, the title shows unconditionally, which I imagine will be redundant for listings embedded insidemod_Tplyr_table
. If that is the case, we can add a flag tolistings_server
:Then
mod_Tplyr_table
would do ashow_title = FALSE
. The flag would not be exposed throughmod_listings
if we believe the title is universally useful.Both @zsigmas and @yashshah1995, this is how it looks when the bulk review panel is not visible:

I believe this is superior to the built-in DT
caption
parameter, because that one centers the title of the table with respect to the total width of the table, which may far exceed the viewport and then the title may end up too far to the right, or even invisible.Here's the same thing with a visible bulk review:

Hotfix checklist
Bumped minor version number on both DESCRIPTION and NEWS.md
Build passes pipeline checks
The new changes do not affect the API
The new changes do not affect the documentation (including screenshots) WILL AFFECT SCREENSHOTS, UPDATED ON A SEPARATE TASK
The new changes do not impact the QC report