Skip to content

Conversation

ml-ebs-ext
Copy link
Contributor

@ml-ebs-ext ml-ebs-ext commented Oct 3, 2025

This PR has to wait for PR #39 to be merged, as it includes it. The diff will be easier to read once that one reaches the test branch.

@zsigmas See if you like the approach. I basically inject an extra div to the right of the bulk review menu, in the top container and populate it through the initComplete DT callback. There's some gratuitous reshaping of code that I hope you don't mind.

@yash See if you like the result. The title consists of the label associated to the dataset inside an h4 HTML heading. If the label is not available, we fall back to the dataset name. Right now, the title shows unconditionally, which I imagine will be redundant for listings embedded inside mod_Tplyr_table. If that is the case, we can add a flag to listings_server:

listings_server <- function(module_id, ..., review = NULL, show_title = TRUE)

Then mod_Tplyr_table would do a show_title = FALSE. The flag would not be exposed through mod_listings if we believe the title is universally useful.

Both @zsigmas and @yashshah1995, this is how it looks when the bulk review panel is not visible:
image
I believe this is superior to the built-in DT caption parameter, because that one centers the title of the table with respect to the total width of the table, which may far exceed the viewport and then the title may end up too far to the right, or even invisible.

Here's the same thing with a visible bulk review:
image

Hotfix checklist

  • Bumped minor version number on both DESCRIPTION and NEWS.md

  • Build passes pipeline checks

  • The new changes do not affect the API

  • The new changes do not affect the documentation (including screenshots) WILL AFFECT SCREENSHOTS, UPDATED ON A SEPARATE TASK

  • The new changes do not impact the QC report

@ml-ebs-ext ml-ebs-ext requested a review from a team as a code owner October 3, 2025 16:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant