Convert Advanced Settings tab to config-r, add QrCode settings (BL-15987)#7730
Convert Advanced Settings tab to config-r, add QrCode settings (BL-15987)#7730andrew-polk merged 1 commit intomasterfrom
Conversation
9418347 to
8a7ce9b
Compare
8a7ce9b to
b05a541
Compare
b05a541 to
92dcd25
Compare
92dcd25 to
43702ad
Compare
43702ad to
be00361
Compare
andrew-polk
left a comment
There was a problem hiding this comment.
@andrew-polk partially reviewed 13 files and all commit messages, and made 2 comments.
Reviewable status: all files reviewed, 2 unresolved discussions (waiting on StephenMcConnel).
src/BloomExe/Collection/CollectionSettingsDialog.cs line 405 at r5 (raw file):
PendingAutomaticallyUpdate && Environment.OSVersion.Version.Major >= 10;
Should this be
PendingAutomaticallyUpdate && AutoUpdateSupportedOnThisPlatform;
?
src/BloomBrowserUI/collection/AdvancedSettingsPanel.tsx line 187 at r5 (raw file):
></ConfigrBoolean> </div> <div
Can you use BloomSubscriptionIndicatorIconAndText?
StephenMcConnel
left a comment
There was a problem hiding this comment.
@StephenMcConnel made 2 comments.
Reviewable status: all files reviewed, 2 unresolved discussions (waiting on andrew-polk).
src/BloomExe/Collection/CollectionSettingsDialog.cs line 405 at r5 (raw file):
Previously, andrew-polk wrote…
PendingAutomaticallyUpdate && Environment.OSVersion.Version.Major >= 10;
Should this be
PendingAutomaticallyUpdate && AutoUpdateSupportedOnThisPlatform;
?
Done.
src/BloomBrowserUI/collection/AdvancedSettingsPanel.tsx line 187 at r5 (raw file):
Previously, andrew-polk wrote…
Can you use BloomSubscriptionIndicatorIconAndText?
Done.
be00361 to
a4a629b
Compare
andrew-polk
left a comment
There was a problem hiding this comment.
@andrew-polk partially reviewed 2 files and all commit messages, and resolved 2 discussions.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on StephenMcConnel).
This change is