Skip to content

Convert Advanced Settings tab to config-r, add QrCode settings (BL-15987)#7730

Merged
andrew-polk merged 1 commit intomasterfrom
BL-15987-AdvancedSettingsQrCode
Mar 16, 2026
Merged

Convert Advanced Settings tab to config-r, add QrCode settings (BL-15987)#7730
andrew-polk merged 1 commit intomasterfrom
BL-15987-AdvancedSettingsQrCode

Conversation

@StephenMcConnel
Copy link
Contributor

@StephenMcConnel StephenMcConnel commented Mar 11, 2026


Open with Devin

This change is Reviewable

@StephenMcConnel StephenMcConnel changed the title Convert Advanced Settings tab to config-r, add QrCode settings (BL-15… Convert Advanced Settings tab to config-r, add QrCode settings (BL-15987) Mar 11, 2026
devin-ai-integration[bot]

This comment was marked as resolved.

@StephenMcConnel StephenMcConnel force-pushed the BL-15987-AdvancedSettingsQrCode branch from 9418347 to 8a7ce9b Compare March 11, 2026 23:26
devin-ai-integration[bot]

This comment was marked as resolved.

@StephenMcConnel StephenMcConnel force-pushed the BL-15987-AdvancedSettingsQrCode branch from 8a7ce9b to b05a541 Compare March 11, 2026 23:36
devin-ai-integration[bot]

This comment was marked as resolved.

@StephenMcConnel StephenMcConnel force-pushed the BL-15987-AdvancedSettingsQrCode branch from b05a541 to 92dcd25 Compare March 12, 2026 15:04
devin-ai-integration[bot]

This comment was marked as resolved.

@StephenMcConnel StephenMcConnel force-pushed the BL-15987-AdvancedSettingsQrCode branch from 92dcd25 to 43702ad Compare March 12, 2026 18:25
devin-ai-integration[bot]

This comment was marked as resolved.

@StephenMcConnel StephenMcConnel force-pushed the BL-15987-AdvancedSettingsQrCode branch from 43702ad to be00361 Compare March 12, 2026 21:51
Copy link
Contributor

@andrew-polk andrew-polk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@andrew-polk partially reviewed 13 files and all commit messages, and made 2 comments.
Reviewable status: all files reviewed, 2 unresolved discussions (waiting on StephenMcConnel).


src/BloomExe/Collection/CollectionSettingsDialog.cs line 405 at r5 (raw file):

PendingAutomaticallyUpdate && Environment.OSVersion.Version.Major >= 10;

Should this be

PendingAutomaticallyUpdate && AutoUpdateSupportedOnThisPlatform;

?


src/BloomBrowserUI/collection/AdvancedSettingsPanel.tsx line 187 at r5 (raw file):

                                ></ConfigrBoolean>
                            </div>
                            <div

Can you use BloomSubscriptionIndicatorIconAndText?

Copy link
Contributor Author

@StephenMcConnel StephenMcConnel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@StephenMcConnel made 2 comments.
Reviewable status: all files reviewed, 2 unresolved discussions (waiting on andrew-polk).


src/BloomExe/Collection/CollectionSettingsDialog.cs line 405 at r5 (raw file):

Previously, andrew-polk wrote…

PendingAutomaticallyUpdate && Environment.OSVersion.Version.Major >= 10;

Should this be

PendingAutomaticallyUpdate && AutoUpdateSupportedOnThisPlatform;

?

Done.


src/BloomBrowserUI/collection/AdvancedSettingsPanel.tsx line 187 at r5 (raw file):

Previously, andrew-polk wrote…

Can you use BloomSubscriptionIndicatorIconAndText?

Done.

@StephenMcConnel StephenMcConnel force-pushed the BL-15987-AdvancedSettingsQrCode branch from be00361 to a4a629b Compare March 16, 2026 15:32
Copy link
Contributor

@andrew-polk andrew-polk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@andrew-polk partially reviewed 2 files and all commit messages, and resolved 2 discussions.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on StephenMcConnel).

@andrew-polk andrew-polk merged commit d1f657d into master Mar 16, 2026
1 of 2 checks passed
@andrew-polk andrew-polk deleted the BL-15987-AdvancedSettingsQrCode branch March 16, 2026 15:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants