Open
Conversation
![devin-ai-integration[bot]](https://avatars.githubusercontent.com/in/811515?s=60&v=4){kind=small}
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
andrew-polk
force-pushed
the
BL15932_Toasts_OnSingleBrowser
branch
from
3f86dc5 to
4250605
Compare
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
Address Devin toast review feedback Tighten toast callback lifecycle Revert unnecessary clobber toast changes
andrew-polk
force-pushed
the
BL15932_Toasts_OnSingleBrowser
branch
from
4250605 to
156aef0
Compare
There was a problem hiding this comment.
🚩 Residual _returnToCollectionTabNotifier references will fail compilation
The field _returnToCollectionTabNotifier (type ToastNotifier) was removed from the class declaration at WorkspaceView.cs:59, but three references remain at lines 1315-1318 in ApplyPostCollectionTabBehavior(). This will cause a compile error. Not reported as a bug per review guidelines (compiler/CI catches it), but the PR cannot merge as-is without addressing these leftover references.
(Refers to lines 1315-1318)
Was this helpful? React with 👍 or 👎 to provide feedback.
JohnThomson
force-pushed
the
oneBrowser5
branch
3 times, most recently
from
6232698 to
a698cbc
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change is