fix(confluence): handle undefined page title crash in slugifyTitle#9
Merged
BjoernSchotte merged 2 commits intoMay 15, 2026
Conversation
Agent-Logs-Url: https://github.com/twogood/atlcli-fork/sessions/b1785bd2-29c4-4ee1-9f57-24a770bf934f Co-authored-by: twogood <189982+twogood@users.noreply.github.com>
Agent-Logs-Url: https://github.com/twogood/atlcli-fork/sessions/b1785bd2-29c4-4ee1-9f57-24a770bf934f Co-authored-by: twogood <189982+twogood@users.noreply.github.com>
Owner
|
Thanks again, David! Clean fix — the widened type signature + early return is exactly the right approach for an API-boundary type mismatch like this. Squash-merged into main. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes a crash when pulling Confluence pages where the API returns a page with a missing (undefined) title:
This happened because
slugifyTitleunconditionally called.toLowerCase()on its argument, but the Confluence API can return pages without atitlefield at runtime despite the TypeScript typing.Changes
Commit 1 — failing test (
packages/confluence/src/hierarchy.test.ts):undefinedas the page title tocomputeFilePath, reproducing the crashCommit 2 — fix (
packages/confluence/src/atlcli-dir.ts):slugifyTitlesignature fromtitle: stringtotitle: string | undefined | null""early for falsy input so the existing|| "page"fallback incomputeFilePathhandles it gracefully