Skip to content

Add TypeScript and static types support to service#16

Open
Coinslist wants to merge 26 commits into
BitgesellOfficial:mainfrom
Coinslist:rewrite-service-in-typescript
Open

Add TypeScript and static types support to service#16
Coinslist wants to merge 26 commits into
BitgesellOfficial:mainfrom
Coinslist:rewrite-service-in-typescript

Conversation

@Coinslist
Copy link
Copy Markdown

@Coinslist Coinslist commented Sep 8, 2022

Summary

  1. Add TypeScript support with adjustable compiler options inside service/tsconfig.json file
  2. Add appropriate types for service/

@Coinslist
Copy link
Copy Markdown
Author

Hi @wu-emma
Please have a look at this (#16)

Thanks

@naftalimurgor
Copy link
Copy Markdown

Hey @Coinslist

  • add npm script to transpile the TypeScript to JavaScript
  • Update Dockerfile for /service
  • Add coverage/ensure all tests pass
    Afterwards we shall review @wu-emma what are your views?

@wu-emma
Copy link
Copy Markdown
Contributor

wu-emma commented Feb 6, 2023

Ok, guys, please resolve merge conflicts, and then ping @van-orton if he would be able to test 'Typescripted'-bridge. Thanks for moving this forward!

@naftalimurgor
Copy link
Copy Markdown

@Coinslist @wu-emma
Awsome. We are on it!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants