Skip to content

lint: make include guard check pass for BGL headers #273

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
RYB-404 wants to merge 1 commit into
base: master
Choose a base branch
from
Open

lint: make include guard check pass for BGL headers #273

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions src/chainparamsseeds.h
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
#ifndef FCO_CHAINPARAMSSEEDS_H
#define FCO_CHAINPARAMSSEEDS_H
#ifndef BGL_CHAINPARAMSSEEDS_H
#define BGL_CHAINPARAMSSEEDS_H
/**
* List of fixed seed nodes for the falco network
* AUTOGENERATED by contrib/seeds/generate-seeds.py
Expand Down Expand Up @@ -33,4 +33,4 @@ static const uint8_t chainparams_seed_test[] = {
0x00,0x00,0x00,0x00,0x00,0x00,0x00,0x00,0x00,0x00,0xff,0xff,0x9e,0xf7,0xd0,0x7f,
0x00,0x00,0x00,0x00,0x00,0x00,0x00,0x00,0x00,0x00,0xff,0xff,0xb9,0x84,0x84,0xa6
};
#endif // FCO_CHAINPARAMSSEEDS_H
#endif // BGL_CHAINPARAMSSEEDS_H
2 changes: 1 addition & 1 deletion src/consensus/amount.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,5 +26,5 @@ static constexpr CAmount COIN = 100000000;
static constexpr CAmount MAX_MONEY = 21000000 * COIN;
inline bool MoneyRange(const CAmount& nValue) { return (nValue >= 0 && nValue <= MAX_MONEY); }

#endif // BGL_CONSENSUS_AMOUNT_H
#endif // BGL_CONSENSUS_AMOUNT_H

4 changes: 4 additions & 0 deletions src/kernel/mempool_persist.h
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,4 @@
#ifndef BGL_KERNEL_MEMPOOL_PERSIST_H
#define BGL_KERNEL_MEMPOOL_PERSIST_H

#endif // BGL_KERNEL_MEMPOOL_PERSIST_H
2 changes: 1 addition & 1 deletion src/policy/feerate.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -77,5 +77,5 @@ class CFeeRate
SERIALIZE_METHODS(CFeeRate, obj) { READWRITE(obj.nSatoshisPerK); }
};

#endif // BGL_POLICY_FEERATE_H
#endif // BGL_POLICY_FEERATE_H

2 changes: 1 addition & 1 deletion src/test/scriptnum10.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -179,5 +179,5 @@ class CScriptNum10
};


#endif // BGL_TEST_BIGNUM_H
#endif // BGL_TEST_SCRIPTNUM10_H

2 changes: 1 addition & 1 deletion src/util/readwritefile.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,4 +25,4 @@ std::pair<bool,std::string> ReadBinaryFile(const fs::path &filename, size_t maxs
*/
bool WriteBinaryFile(const fs::path &filename, const std::string &data);

#endif /* BGL_UTIL_READWRITEFILE_H */
#endif // BGL_UTIL_READWRITEFILE_H
2 changes: 1 addition & 1 deletion src/util/trace.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,4 +44,4 @@
#endif


#endif /* BGL_UTIL_TRACE_H */
#endif // BGL_UTIL_TRACE_H
2 changes: 1 addition & 1 deletion src/zmq/zmqrpc.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,4 +9,4 @@ class CRPCTable;

void RegisterZMQRPCCommands(CRPCTable& t);

#endif // BGL_ZMQ_ZMRRPC_H
#endif // BGL_ZMQ_ZMQRPC_H
14 changes: 14 additions & 0 deletions test/lint/lint-include-guards.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,21 @@
HEADER_ID_SUFFIX = '_H'

EXCLUDE_FILES_WITH_PREFIX = ['contrib/devtools/bitcoin-tidy',
'contrib/devtools/BGL-tidy',
'build_msvc/BGL_config.h',
'src/crypto/ctaes',
'src/assumptions.h',
'src/checkmem.h',
'src/config/BGL-config.h',
'src/crc32c_arm64_check.h',
'src/crypto/sha3/sha3.h',
'src/ecmult_compute_table',
'src/ecmult_gen_compute_table',
'src/hsort',
'src/int128',
'src/precomputed_ecmult',
'src/selftest.h',
'src/testutil.h',
'src/tinyformat.h',
'src/bench/nanobench.h',
'src/test/fuzz/FuzzedDataProvider.h'] + SHARED_EXCLUDED_SUBTREES
Expand Down