Skip to content

Conversation

@wjunLu
Copy link

@wjunLu wjunLu commented Oct 25, 2025

Please do not merge, it's still not ready.

@jwokaty
Copy link
Collaborator

jwokaty commented Nov 3, 2025

@wjunLu Is this ready to merge?

@hpages
Copy link
Contributor

hpages commented Nov 3, 2025

@wjunLu You have BBS_NB_CPU=25 which seems excessive for a machine with 32 logical cpus. The naming could arguably be better but BBS_NB_CPU is actually the default number of workers to use when more specific values like BBS_INSTALL_NB_CPU, BBS_BUILD_NB_CPU, or BBS_CHECK_NB_CPU are not specified. Since you're not defining BBS_INSTALL_NB_CPU, this means that 25 workers will be used for the INSTALL stage, which is a lot!

I recommend that you set BBS_NB_CPU to no more than 20 e.g. maybe 18 would be a good start. Reducing the load on the machine during INSTALL might help with all the installation failures that we've observed in the past on the machine.

@wjunLu
Copy link
Author

wjunLu commented Nov 4, 2025

image

@jwokaty It seems ready to merge now

@hpages
Copy link
Contributor

hpages commented Nov 4, 2025

@wjunLu Make sure to check my comment above.

@wjunLu
Copy link
Author

wjunLu commented Nov 4, 2025

@wjunLu Make sure to check my comment above.

@hpages So Sorry! I missed your comment.
As for BBS_NB_CPU=25, it's the same parameter we used on 3.21 version. I will try to reduce that and run the build again, to see if there are some changes.

@hpages
Copy link
Contributor

hpages commented Nov 4, 2025

As for BBS_NB_CPU=25, it's the same parameter we used on 3.21 version

IIRC kunpeng2 already had a slightly more than expected number of installation failures in BioC 3.21, and using such a high number of workers for the INSTALL stage might have contributed to that.

I will try to reduce that and run the build again, to see if there are some changes.

Excellent! Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants