Skip to content

Expand GIMME type hints #45

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
JoshLoecker wants to merge 19 commits into
base: master
Choose a base branch
from
Open

Expand GIMME type hints #45

JoshLoecker wants to merge 19 commits into from

Conversation

@JoshLoecker
Copy link

@JoshLoecker JoshLoecker commented Oct 1, 2025

This pull request does the following to the GIMME reconstruction method:

  1. Use generic type hints (e.g., Iterable, Sequence instead of more strict types (e.g., list, tuple)
  2. Use numpy.typing.NDArray for numpy typing
  3. Bumps minimum numpy version to 1.20, as numpy.typing did not exist before this version

@JoshLoecker
Added pyproject with minimum dependencies
991cd74
@JoshLoecker
fix: pyproject for installation setup
c423b5e
@JoshLoecker
fix: quotations
f118f59
@JoshLoecker
fix: project urls
9a5dd1a
@JoshLoecker
revert: include dependencies under project
7dd6b8b
@JoshLoecker
fix: quotations
8fe364c
@JoshLoecker
revert: license location
9b53b71
@JoshLoecker
Fix description
3b73024
@JoshLoecker
Merge pull request #1 from JoshLoecker/update_dependencies
d5648d8 
Added pyproject with minimum dependencies
@JoshLoecker
feat: allow setting solver
45b15b4
@JoshLoecker
fix: set solver in iMATProperties class
b6ba44e 
Signed-off-by: Josh Loecker <[email protected]>
@JoshLoecker
Merge pull request #2 from JoshLoecker/feat/allow-setting-solver
048edc8 
Allow setting `solver`
@JoshLoecker
style(ruff): automatic formatting with ruff
2ad0936
@JoshLoecker
chore(dev): import types for use
fcc7120
@JoshLoecker
feat(dev): use Optional for optional types
3621675
@JoshLoecker
feat (dev): use generic types instead of list or tuple
e11f5fd
@JoshLoecker
feat(dev): raise error if required argument not given
411a1d1
@JoshLoecker
feat(dev): use isinstance for consistent runtime type checks
9ac84db
@JoshLoecker
chore(dev): require numpy >=1.20
43ea88e
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@JoshLoecker