fix(cli): support multiple --header flags in ARGOCD_OPTS Fixes #24065#2
Open
Bharath420 wants to merge 1 commit intomasterfrom
Open
fix(cli): support multiple --header flags in ARGOCD_OPTS Fixes #24065#2Bharath420 wants to merge 1 commit intomasterfrom
Bharath420 wants to merge 1 commit intomasterfrom
Conversation
…oj#24065 The ARGOCD_OPTS environment variable now correctly handles multiple instances of the same flag (e.g., multiple --header flags) by concatenating values with commas, making it consistent with direct CLI usage. Signed-off-by: Bharath Madvar <39058743+Bharath420@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes argoproj#24065
Summary
The ARGOCD_OPTS environment variable now correctly handles multiple instances of the same flag (e.g., multiple --header flags) by concatenating values with commas, making it consistent with direct CLI usage.
Problem
The
argocdCLI accepts the--headeroption multiple times when passed directly on the command line. However, when using theARGOCD_OPTSenvironment variable, only a single--headeris recognized. This is inconsistent with CLI behavior.Current behavior: