Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR adds computer network laboratory reports for various networking protocols and technologies. The submission includes comprehensive experimental documentation, code implementations, and data analysis for 7 different networking labs covering protocols from Ethernet to Socket Programming.
Key Changes:
- Added 7 laboratory reports covering fundamental networking protocols (Ethernet, IPv4, ARP, UDP, TCP, Socket Programming)
- Included practical implementations with client-server socket programming in C
- Added network analysis results with Wireshark packet captures and detailed protocol examination
Reviewed Changes
Copilot reviewed 21 out of 78 changed files in this pull request and generated 5 comments.
Show a summary per file
| File | Description |
|---|---|
| docs/undergraduate/软件工程学院/计算机网络/README.md | Main index page listing all laboratory reports with navigation links |
| docs/undergraduate/软件工程学院/计算机网络/lab/lab*/lib*.md | Laboratory report documents for each networking protocol experiment |
| docs/undergraduate/软件工程学院/计算机网络/lab/lab7/*.c | Socket programming implementations (client.c and server.c) |
| docs/undergraduate/软件工程学院/计算机网络/lab/lab7/*.txt | Output logs and test data from socket programming experiments |
| docs/undergraduate/软件工程学院/计算机网络/lab/lab*/*.txt | Various network configuration files and command outputs |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
There was a problem hiding this comment.
The len variable is used uninitialized in the accept() call. It should be initialized to sizeof(sin) before the call to properly specify the size of the address structure.
| while(1) { | |
| while(1) { | |
| len = sizeof(sin); |
There was a problem hiding this comment.
Assignment in while condition should use comparison operator. The current code assigns the return value of recv() to len, but this overwrites the address length from accept(). Consider using a separate variable for the receive length.
There was a problem hiding this comment.
Duplicate include of unistd.h on consecutive lines. Remove one of the duplicate includes.
| #include <unistd.h> |

No description provided.