Add semantic-cache package: Valkey-native LLM cache with observability#55
Merged
Add semantic-cache package: Valkey-native LLM cache with observability#55
Conversation
Standalone semantic cache backed by Valkey Search vector similarity. Includes OpenTelemetry tracing, Prometheus metrics, LangChain and Vercel AI SDK adapters, runnable example with mock embedder, and Jekyll docs page. Handles Valkey Search 1.2 API divergences from
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 3 potential issues.
Autofix Details
Bugbot Autofix prepared fixes for all 3 issues found in the latest run.
- ✅ Fixed: Dimension fallback returns 0 instead of probing embedFn
initialize()now probesembedFnwhenever FT.INFO dimension parsing returns 0, preventing_dimensionfrom being stuck at 0.
- ✅ Fixed: iovalkey listed in both dependencies and peerDependencies
- Removed
iovalkeyfromdependenciesand kept it as a peer dependency while adding it todevDependenciesfor local tests.
- Removed
- ✅ Fixed: Development context files with local paths committed
- Deleted both committed
.betterdb_context.mdartifacts and added.betterdb_context.mdto root.gitignoreto prevent recommits.
- Deleted both committed
Or push these changes by commenting:
@cursor push d71c559b52
Preview (d71c559b52)
diff --git a/.gitignore b/.gitignore
--- a/.gitignore
+++ b/.gitignore
@@ -70,3 +70,4 @@
packages/mcp/.mcpregistry_github_token
.gitignore
packages/mcp/.mcpregistry_registry_token
+.betterdb_context.md
diff --git a/packages/semantic-cache/.betterdb_context.md b/packages/semantic-cache/.betterdb_context.md
deleted file mode 100644
--- a/packages/semantic-cache/.betterdb_context.md
+++ /dev/null
@@ -1,93 +1,0 @@
-
-
-## File History: /home/kristiyan/projects/valkey/monitor/packages/shared/package.json
-- Implemented SSH tunnel support for remote Valkey/Redis connections and updated package.json and README.md for improved marketplace discoverability of the feature. (2026-03-04)
-- Fixed 5 high/medium/low severity review findings for Valkey Search tree provider: input validation, prefix matching, parallel FT.INFO calls, context-key gating, and formatting. (2026-03-18)
-- Removed Docker, rewrote install to compile binaries on user machine, made npm package source-only with config fallback for standalone executables, added validation gate before publish. (2026-03-02)
-
-## File History: /home/kristiyan/projects/valkey/monitor/packages/shared/package.json
-- Implemented SSH tunnel support for remote Valkey/Redis connections and updated package.json and README.md for improved marketplace discoverability of the feature. (2026-03-04)
-- Fixed 5 high/medium/low severity review findings for Valkey Search tree provider: input validation, prefix matching, parallel FT.INFO calls, context-key gating, and formatting. (2026-03-18)
-- Removed Docker, rewrote install to compile binaries on user machine, made npm package source-only with config fallback for standalone executables, added validation gate before publish. (2026-03-02)
-
-## File History: /home/kristiyan/projects/valkey/monitor/.github/workflows/mcp-release.yml
-- Scaffolded @betterdb/mcp package with MCP server, REST API integration via agent token auth, and GitHub Actions publishing workflow matching the agent release pattern. (2026-03-12)
-
-## File History: /home/kristiyan/projects/valkey/monitor/packages/semantic-cache/README.md
-- Implemented SSH tunnel support for remote Valkey/Redis connections and updated package.json and README.md for improved marketplace discoverability of the feature. (2026-03-04)
-- Removed Docker, rewrote install to compile binaries on user machine, made npm package source-only with config fallback for standalone executables, added validation gate before publish. (2026-03-02)
-
-## File History: /home/kristiyan/projects/valkey/monitor/packages/semantic-cache/README.md
-- Implemented SSH tunnel support for remote Valkey/Redis connections and updated package.json and README.md for improved marketplace discoverability of the feature. (2026-03-04)
-- Removed Docker, rewrote install to compile binaries on user machine, made npm package source-only with config fallback for standalone executables, added validation gate before publish. (2026-03-02)
-
-## File History: /home/kristiyan/projects/valkey/monitor/packages/semantic-cache/README.md
-- Implemented SSH tunnel support for remote Valkey/Redis connections and updated package.json and README.md for improved marketplace discoverability of the feature. (2026-03-04)
-- Removed Docker, rewrote install to compile binaries on user machine, made npm package source-only with config fallback for standalone executables, added validation gate before publish. (2026-03-02)
-
-## File History: /home/kristiyan/projects/valkey/monitor/packages/semantic-cache/package.json
-- Implemented SSH tunnel support for remote Valkey/Redis connections and updated package.json and README.md for improved marketplace discoverability of the feature. (2026-03-04)
-- Fixed 5 high/medium/low severity review findings for Valkey Search tree provider: input validation, prefix matching, parallel FT.INFO calls, context-key gating, and formatting. (2026-03-18)
-- Removed Docker, rewrote install to compile binaries on user machine, made npm package source-only with config fallback for standalone executables, added validation gate before publish. (2026-03-02)
-
-## File History: /home/kristiyan/projects/valkey/monitor/packages/semantic-cache/README.md
-- Implemented SSH tunnel support for remote Valkey/Redis connections and updated package.json and README.md for improved marketplace discoverability of the feature. (2026-03-04)
-- Removed Docker, rewrote install to compile binaries on user machine, made npm package source-only with config fallback for standalone executables, added validation gate before publish. (2026-03-02)
-
-## File History: /home/kristiyan/projects/valkey/monitor/packages/semantic-cache/examples/basic/package.json
-- Implemented SSH tunnel support for remote Valkey/Redis connections and updated package.json and README.md for improved marketplace discoverability of the feature. (2026-03-04)
-- Fixed 5 high/medium/low severity review findings for Valkey Search tree provider: input validation, prefix matching, parallel FT.INFO calls, context-key gating, and formatting. (2026-03-18)
-- Removed Docker, rewrote install to compile binaries on user machine, made npm package source-only with config fallback for standalone executables, added validation gate before publish. (2026-03-02)
-
-## File History: /home/kristiyan/projects/valkey/monitor/packages/semantic-cache/examples/basic/README.md
-- Implemented SSH tunnel support for remote Valkey/Redis connections and updated package.json and README.md for improved marketplace discoverability of the feature. (2026-03-04)
-- Removed Docker, rewrote install to compile binaries on user machine, made npm package source-only with config fallback for standalone executables, added validation gate before publish. (2026-03-02)
-
-## File History: /home/kristiyan/projects/valkey/monitor/packages/semantic-cache/package.json
-- Implemented SSH tunnel support for remote Valkey/Redis connections and updated package.json and README.md for improved marketplace discoverability of the feature. (2026-03-04)
-- Fixed 5 high/medium/low severity review findings for Valkey Search tree provider: input validation, prefix matching, parallel FT.INFO calls, context-key gating, and formatting. (2026-03-18)
-- Removed Docker, rewrote install to compile binaries on user machine, made npm package source-only with config fallback for standalone executables, added validation gate before publish. (2026-03-02)
-
-## File History: /home/kristiyan/projects/valkey/monitor/packages/semantic-cache/package.json
-- Implemented SSH tunnel support for remote Valkey/Redis connections and updated package.json and README.md for improved marketplace discoverability of the feature. (2026-03-04)
-- Fixed 5 high/medium/low severity review findings for Valkey Search tree provider: input validation, prefix matching, parallel FT.INFO calls, context-key gating, and formatting. (2026-03-18)
-- Removed Docker, rewrote install to compile binaries on user machine, made npm package source-only with config fallback for standalone executables, added validation gate before publish. (2026-03-02)
-
-## File History: /home/kristiyan/projects/valkey/monitor/packages/semantic-cache/src/index.ts
-- Removed Docker, rewrote install to compile binaries on user machine, made npm package source-only with config fallback for standalone executables, added validation gate before publish. (2026-03-02)
-
-## File History: /home/kristiyan/projects/valkey/monitor/packages/semantic-cache/README.md
-- Implemented SSH tunnel support for remote Valkey/Redis connections and updated package.json and README.md for improved marketplace discoverability of the feature. (2026-03-04)
-- Removed Docker, rewrote install to compile binaries on user machine, made npm package source-only with config fallback for standalone executables, added validation gate before publish. (2026-03-02)
-
-## File History: /home/kristiyan/projects/valkey/monitor/packages/semantic-cache/README.md
-- Implemented SSH tunnel support for remote Valkey/Redis connections and updated package.json and README.md for improved marketplace discoverability of the feature. (2026-03-04)
-- Removed Docker, rewrote install to compile binaries on user machine, made npm package source-only with config fallback for standalone executables, added validation gate before publish. (2026-03-02)
-
-## File History: /home/kristiyan/projects/valkey/monitor/packages/semantic-cache/README.md
-- Implemented SSH tunnel support for remote Valkey/Redis connections and updated package.json and README.md for improved marketplace discoverability of the feature. (2026-03-04)
-- Removed Docker, rewrote install to compile binaries on user machine, made npm package source-only with config fallback for standalone executables, added validation gate before publish. (2026-03-02)
-
-## File History: /home/kristiyan/projects/valkey/monitor/packages/semantic-cache/README.md
-- Implemented SSH tunnel support for remote Valkey/Redis connections and updated package.json and README.md for improved marketplace discoverability of the feature. (2026-03-04)
-- Removed Docker, rewrote install to compile binaries on user machine, made npm package source-only with config fallback for standalone executables, added validation gate before publish. (2026-03-02)
-
-## File History: /home/kristiyan/projects/valkey/monitor/packages/semantic-cache/README.md
-- Implemented SSH tunnel support for remote Valkey/Redis connections and updated package.json and README.md for improved marketplace discoverability of the feature. (2026-03-04)
-- Removed Docker, rewrote install to compile binaries on user machine, made npm package source-only with config fallback for standalone executables, added validation gate before publish. (2026-03-02)
-
-## File History: /home/kristiyan/projects/valkey/monitor/packages/semantic-cache/README.md
-- Implemented SSH tunnel support for remote Valkey/Redis connections and updated package.json and README.md for improved marketplace discoverability of the feature. (2026-03-04)
-- Removed Docker, rewrote install to compile binaries on user machine, made npm package source-only with config fallback for standalone executables, added validation gate before publish. (2026-03-02)
-
-## File History: /home/kristiyan/projects/valkey/monitor/packages/semantic-cache/README.md
-- Implemented SSH tunnel support for remote Valkey/Redis connections and updated package.json and README.md for improved marketplace discoverability of the feature. (2026-03-04)
-- Removed Docker, rewrote install to compile binaries on user machine, made npm package source-only with config fallback for standalone executables, added validation gate before publish. (2026-03-02)
-
-## File History: /home/kristiyan/projects/valkey/monitor/packages/semantic-cache/README.md
-- Implemented SSH tunnel support for remote Valkey/Redis connections and updated package.json and README.md for improved marketplace discoverability of the feature. (2026-03-04)
-- Removed Docker, rewrote install to compile binaries on user machine, made npm package source-only with config fallback for standalone executables, added validation gate before publish. (2026-03-02)
-
-## File History: /home/kristiyan/projects/valkey/monitor/packages/semantic-cache/README.md
-- Implemented SSH tunnel support for remote Valkey/Redis connections and updated package.json and README.md for improved marketplace discoverability of the feature. (2026-03-04)
-- Removed Docker, rewrote install to compile binaries on user machine, made npm package source-only with config fallback for standalone executables, added validation gate before publish. (2026-03-02)
\ No newline at end of file
diff --git a/packages/semantic-cache/examples/basic/.betterdb_context.md b/packages/semantic-cache/examples/basic/.betterdb_context.md
deleted file mode 100644
--- a/packages/semantic-cache/examples/basic/.betterdb_context.md
+++ /dev/null
@@ -1,57 +1,0 @@
-
-
-## File History: /home/kristiyan/projects/valkey/monitor/packages/semantic-cache/examples/basic/README.md
-- Implemented SSH tunnel support for remote Valkey/Redis connections and updated package.json and README.md for improved marketplace discoverability of the feature. (2026-03-04)
-- Removed Docker, rewrote install to compile binaries on user machine, made npm package source-only with config fallback for standalone executables, added validation gate before publish. (2026-03-02)
-
-## File History: /home/kristiyan/projects/valkey/monitor/packages/semantic-cache/examples/basic/README.md
-- Implemented SSH tunnel support for remote Valkey/Redis connections and updated package.json and README.md for improved marketplace discoverability of the feature. (2026-03-04)
-- Removed Docker, rewrote install to compile binaries on user machine, made npm package source-only with config fallback for standalone executables, added validation gate before publish. (2026-03-02)
-
-## File History: /home/kristiyan/projects/valkey/monitor/packages/semantic-cache/examples/basic/README.md
-- Implemented SSH tunnel support for remote Valkey/Redis connections and updated package.json and README.md for improved marketplace discoverability of the feature. (2026-03-04)
-- Removed Docker, rewrote install to compile binaries on user machine, made npm package source-only with config fallback for standalone executables, added validation gate before publish. (2026-03-02)
-
-## File History: /home/kristiyan/projects/valkey/monitor/packages/semantic-cache/src/index.ts
-- Removed Docker, rewrote install to compile binaries on user machine, made npm package source-only with config fallback for standalone executables, added validation gate before publish. (2026-03-02)
-
-## File History: /home/kristiyan/projects/valkey/monitor/packages/semantic-cache/src/index.ts
-- Removed Docker, rewrote install to compile binaries on user machine, made npm package source-only with config fallback for standalone executables, added validation gate before publish. (2026-03-02)
-
-## File History: /home/kristiyan/projects/valkey/monitor/packages/semantic-cache/README.md
-- Implemented SSH tunnel support for remote Valkey/Redis connections and updated package.json and README.md for improved marketplace discoverability of the feature. (2026-03-04)
-- Removed Docker, rewrote install to compile binaries on user machine, made npm package source-only with config fallback for standalone executables, added validation gate before publish. (2026-03-02)
-
-## File History: /home/kristiyan/projects/valkey/monitor/packages/semantic-cache/src/index.ts
-- Removed Docker, rewrote install to compile binaries on user machine, made npm package source-only with config fallback for standalone executables, added validation gate before publish. (2026-03-02)
-
-## File History: /home/kristiyan/projects/valkey/monitor/packages/semantic-cache/src/index.ts
-- Removed Docker, rewrote install to compile binaries on user machine, made npm package source-only with config fallback for standalone executables, added validation gate before publish. (2026-03-02)
-
-## File History: /home/kristiyan/projects/valkey/monitor/packages/semantic-cache/README.md
-- Implemented SSH tunnel support for remote Valkey/Redis connections and updated package.json and README.md for improved marketplace discoverability of the feature. (2026-03-04)
-- Removed Docker, rewrote install to compile binaries on user machine, made npm package source-only with config fallback for standalone executables, added validation gate before publish. (2026-03-02)
-
-## File History: /home/kristiyan/projects/valkey/monitor/packages/semantic-cache/package.json
-- Implemented SSH tunnel support for remote Valkey/Redis connections and updated package.json and README.md for improved marketplace discoverability of the feature. (2026-03-04)
-- Fixed 5 high/medium/low severity review findings for Valkey Search tree provider: input validation, prefix matching, parallel FT.INFO calls, context-key gating, and formatting. (2026-03-18)
-- Removed Docker, rewrote install to compile binaries on user machine, made npm package source-only with config fallback for standalone executables, added validation gate before publish. (2026-03-02)
-
-## File History: /home/kristiyan/projects/valkey/monitor/packages/semantic-cache/src/index.ts
-- Removed Docker, rewrote install to compile binaries on user machine, made npm package source-only with config fallback for standalone executables, added validation gate before publish. (2026-03-02)
-
-## File History: /home/kristiyan/projects/valkey/monitor/packages/semantic-cache/README.md
-- Implemented SSH tunnel support for remote Valkey/Redis connections and updated package.json and README.md for improved marketplace discoverability of the feature. (2026-03-04)
-- Removed Docker, rewrote install to compile binaries on user machine, made npm package source-only with config fallback for standalone executables, added validation gate before publish. (2026-03-02)
-
-## File History: /home/kristiyan/projects/valkey/monitor/packages/semantic-cache/README.md
-- Implemented SSH tunnel support for remote Valkey/Redis connections and updated package.json and README.md for improved marketplace discoverability of the feature. (2026-03-04)
-- Removed Docker, rewrote install to compile binaries on user machine, made npm package source-only with config fallback for standalone executables, added validation gate before publish. (2026-03-02)
-
-## File History: /home/kristiyan/projects/valkey/monitor/packages/semantic-cache/README.md
-- Implemented SSH tunnel support for remote Valkey/Redis connections and updated package.json and README.md for improved marketplace discoverability of the feature. (2026-03-04)
-- Removed Docker, rewrote install to compile binaries on user machine, made npm package source-only with config fallback for standalone executables, added validation gate before publish. (2026-03-02)
-
-## File History: /home/kristiyan/projects/valkey/monitor/packages/semantic-cache/README.md
-- Implemented SSH tunnel support for remote Valkey/Redis connections and updated package.json and README.md for improved marketplace discoverability of the feature. (2026-03-04)
-- Removed Docker, rewrote install to compile binaries on user machine, made npm package source-only with config fallback for standalone executables, added validation gate before publish. (2026-03-02)
\ No newline at end of file
diff --git a/packages/semantic-cache/package.json b/packages/semantic-cache/package.json
--- a/packages/semantic-cache/package.json
+++ b/packages/semantic-cache/package.json
@@ -30,13 +30,13 @@
},
"dependencies": {
"@opentelemetry/api": "^1.9.0",
- "iovalkey": "^0.2.0",
"prom-client": "^15.1.3"
},
"devDependencies": {
"@langchain/core": ">=0.3.0",
"@types/node": "^20.0.0",
"ai": ">=4.0.0",
+ "iovalkey": "^0.2.0",
"typescript": "^5.4.0",
"vitest": "^1.6.0"
},
diff --git a/packages/semantic-cache/src/SemanticCache.ts b/packages/semantic-cache/src/SemanticCache.ts
--- a/packages/semantic-cache/src/SemanticCache.ts
+++ b/packages/semantic-cache/src/SemanticCache.ts
@@ -70,7 +70,9 @@
try {
try {
const info = (await this.client.call('FT.INFO', this.indexName)) as unknown[];
- this._dimension = this.parseDimensionFromInfo(info);
+ const parsedDimension = this.parseDimensionFromInfo(info);
+ this._dimension =
+ parsedDimension > 0 ? parsedDimension : await this.probeDimension();
this._initialized = true;
} catch (err: unknown) {
const message =
@@ -83,18 +85,8 @@
message.toLowerCase().includes('no such index') ||
message.toLowerCase().includes('not found')
) {
- let probeVec: number[];
- try {
- probeVec = await this.embedFn('probe');
- } catch (embedErr) {
- throw new EmbeddingError(
- `embedFn failed: ${embedErr instanceof Error ? embedErr.message : String(embedErr)}`,
- embedErr,
- );
- }
+ this._dimension = await this.probeDimension();
- this._dimension = probeVec.length;
-
try {
await this.client.call(
'FT.CREATE',
@@ -570,6 +562,18 @@
this._initialized = false;
}
+ private async probeDimension(): Promise<number> {
+ try {
+ const probeVec = await this.embedFn('probe');
+ return probeVec.length;
+ } catch (embedErr) {
+ throw new EmbeddingError(
+ `embedFn failed: ${embedErr instanceof Error ? embedErr.message : String(embedErr)}`,
+ embedErr,
+ );
+ }
+ }
+
private parseDimensionFromInfo(info: unknown[]): number {
// FT.INFO returns a flat array: [key, value, key, value, ...]
// We need to find the 'attributes' section which contains field definitions.
@@ -616,7 +620,7 @@
}
}
- // Fallback: if we can't parse dimension from info, call embedFn
+ // Fallback probing happens in initialize() when this returns 0.
return 0;
}
}
diff --git a/pnpm-lock.yaml b/pnpm-lock.yaml
--- a/pnpm-lock.yaml
+++ b/pnpm-lock.yaml
@@ -376,9 +376,6 @@
'@opentelemetry/api':
specifier: ^1.9.0
version: 1.9.0
- iovalkey:
- specifier: ^0.2.0
- version: 0.2.2
prom-client:
specifier: ^15.1.3
version: 15.1.3
@@ -392,6 +389,9 @@
ai:
specifier: '>=4.0.0'
version: 6.0.134(zod@4.3.5)
+ iovalkey:
+ specifier: ^0.2.0
+ version: 0.2.2
typescript:
specifier: ^5.4.0
version: 5.9.3This Bugbot Autofix run was free. To enable autofix for future PRs, go to the Cursor dashboard.
…Fn('probe') when parseDimensionFromInfo returns 0
- Remove iovalkey from dependencies (keep as peerDependency only)
- Add _initialized guard to invalidate() and indexInfo()
- Fix search_latency_ms to exclude embedding time
- Fix race condition in adapter ensureInitialized() with promise guard
- Add security note to filter parameter JSDoc
- Fix CI verify step swallowing publish failures - Update docs: stale error class names and invalidate return type
- Add promise guard with failure reset to initialize() and adapter ensureInitialized() - Remove stale close() entry and old error class names from CHANGELOG - Add ESM import paths to package.json exports map - Add security JSDoc to invalidate() filter parameter
- Reset _initPromise in flush() so initialize() works after flush - Record search_latency_ms and embedding_latency_ms on miss spans - Add _initialized guard to stats() - Document k > 1 as reserved for future use
- Re-throw EmbeddingError before index-not-found pattern matching - Tighten 'not found' match to 'not found in database' to avoid masking unrelated errors - Add embedding dimension validation to check() - Move _initialized/_initPromise reset to start of flush()
| if (!text) return; | ||
| await this.cache.store(prompt, text, { | ||
| model: this.modelHash(llm_string), | ||
| }); |
There was a problem hiding this comment.
LangChain adapter stores model hash regardless of filter setting
Low Severity
The update() method always stores model: this.modelHash(llm_string) regardless of the filterByModel setting. When filterByModel is false, lookup() doesn't filter by model, but update() still writes a hashed model tag to every entry. This creates an inconsistency: if a user later enables filterByModel, old entries will only match the model that originally stored them — a silent behavior change that may be surprising.
Extract traced(), embed(), recordStat(), assertInitialized(), assertDimension(), isIndexNotFoundError(), errMsg() helpers to replace code that was duplicated 2-6x across methods. Flatten _doInitialize into detectOrCreateIndex(). Replace magic 1000 with INVALIDATE_BATCH_SIZE constant. Deduplicate STOP_WORDS in examples.
- Rename detectOrCreateIndex → ensureIndexAndGetDimension - Change embed() to return durationSec (seconds) matching traced() - Inline parseScore() at its single call site - Clarify traced() JSDoc: callers must not call span.end/setStatus
| msg.includes('no such index') || | ||
| msg.includes('not found') | ||
| ); | ||
| } |
There was a problem hiding this comment.
Overly broad error matching silently swallows unrelated errors
High Severity
isIndexNotFoundError checks msg.includes('not found'), which is far too broad. It matches any error containing "not found" — e.g., "ERR command not found" (when the valkey-search module isn't loaded), "module not found", or "Field not found in schema". This causes flush() and ensureIndexAndGetDimension() to silently swallow real errors, treating them as a benign "index doesn't exist" condition. In ensureIndexAndGetDimension, this means the code falls through to re-creating the index instead of surfacing the actual failure. The documented Valkey Search 1.2 message is "Index with name '...' not found in database 0" — the check needs to be more specific, such as requiring both 'index' and 'not found' in the message.
Additional Locations (2)
| if (d > 0) dim = d; | ||
| } | ||
| } | ||
| } |
There was a problem hiding this comment.
Dimension parser iterates by 1 instead of 2
Low Severity
The inner loop in parseDimensionFromInfo uses j++ to iterate over FT.INFO attribute arrays that are structured as flat key-value pairs (and similarly the nested k loop). This treats every element as a potential key, including values from the previous pair. It works today because no known FT.INFO values collide with the checked keys ('type', 'dim', 'index', 'dimensions'), but it's semantically incorrect for key-value pair iteration and fragile against future format changes.
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
There are 4 total unresolved issues (including 3 from previous reviews).
Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Standalone semantic cache backed by Valkey Search vector similarity. Includes OpenTelemetry tracing, Prometheus metrics, LangChain and Vercel AI SDK adapters, runnable example with mock embedder, and Jekyll docs page. Handles Valkey Search 1.2 API divergences from
Note
Medium Risk
Introduces a new production-facing package plus an automated npm/GitHub release workflow; risk is mainly around correctness of Valkey Search command usage and publish/versioning automation.
Overview
Adds a new
@betterdb/semantic-cachepackage: a Valkey/Redis-backed semantic cache that stores embeddings in hashes, performs vector KNN lookups viaFT.SEARCH, supports TTL + batch invalidation, and emits built-in OpenTelemetry spans and Prometheus metrics.Includes framework integrations via optional subpath exports (
/langchainadapter and/aimiddleware), plus unit + integration tests and a runnable example (with a mock embedder + Docker Valkey bundle) to validate end-to-end behavior.Adds docs pages under
docs/packages/*, aCHANGELOG.md/packageREADME.md, updatespnpm-lock.yaml, and introduces a GitHub Actions workflow to publish onsemantic-cache-v*tags (build, publish with provenance, create GitHub release, then verify the npm artifact).Written by Cursor Bugbot for commit ab06c6d. This will update automatically on new commits. Configure here.