Simplify implementation of Enum::fromKey to native enum with dynamic class const fetch
#365
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…c class const fetch
spawnia
force-pushed
the
simplify-to-native-enum-from-key
branch
from
3c5b91e to
c4c3c1e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issue/Intent
Simplifies how
Enum::fromKeyis reimplemented when PHP 8.3 is available and thus dynamic class constant fetch can be used.Changes
When using PHP 8.3 or newer, the conversion result will be simplified.
Breaking changes
None, backwards compatibility with older PHP versions is given.