Support Laravel 12 #361
Closed
Support Laravel 12 #361
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Owner
|
I don't have a problem with updating support for this package, however I strongly suggest that you migrate away from this package if you are using a modern version of Laravel/PHP and use native enums. |
Owner
|
Look like there are some issues to address with return types. Can you take a look @ahmedbally ? |
Author
|
sure on it |
Author
|
fixed please check |
3 tasks
Collaborator
|
These updates are often quite tricky. I am giving it a shot with #363 too. |
Collaborator
|
Fixed with #363. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issue/Intent
Changes
Breaking changes