Repository navigation
Stop blank lines growing on every reformat - #10
Merged
Merged
Conversation
to_openscad puts two blank lines after a function/module declaration -- and added them to any the source already had there. A re-parse keeps the blank lines before a comment as BlankLine nodes, so each reformat grew that gap by two. The gap is now the larger of the two, not the sum. On BOSL2, 55 of the 91 valid files reformatted to different text a second time, differing only in blank lines; now none do. Every file is identical on a second reformat, with the same program and all 45,635 comments. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This was referenced Sep 25, 2026
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
to_openscadadds two blank lines after a function or module declaration, on top of any blank lines already in the source. A re-parse keeps the blank lines before a comment asBlankLinenodes, so every reformat made that gap two lines bigger. The gap is now the larger of the two, not the sum.On BOSL2: 55 of the 91 valid files used to reformat to different text on a second pass, differing only in blank lines. Now every file is identical on a second reformat, with the same program and all 45,635 comments kept. This closes the last reformat item in
TODO.md.Tests: 3 new; 2 of them fail on
master.🤖 Generated with Claude Code