Skip to content

Made fallback for missing recipients/header.#11

Open
5eeman wants to merge 4 commits intoBdaya-Dev:mainfrom
5eeman:main
Open

Made fallback for missing recipients/header.#11
5eeman wants to merge 4 commits intoBdaya-Dev:mainfrom
5eeman:main

Conversation

@5eeman
Copy link
Copy Markdown

@5eeman 5eeman commented Oct 28, 2025

No description provided.

@5eeman
Copy link
Copy Markdown
Author

5eeman commented Nov 18, 2025

@ahmednfwela can you review this PR, please?

@ahmednfwela
Copy link
Copy Markdown
Member

hi @5eeman sorry for the delay

is there a reason to lower the dependency constraints?

@5eeman
Copy link
Copy Markdown
Author

5eeman commented Nov 19, 2025

Hi!
No worries, all good!
The only change in crypto_keys_plus 0.5.0 is change of pointycastle dependency from 3.x.x to 4.0.0
So if we will lower this dependency constraint it will allow clients to use both 3.x.x and 4.0.0 versions of it.

Copy link
Copy Markdown
Member

@ahmednfwela ahmednfwela left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your contribution, LGTM

@ahmednfwela
Copy link
Copy Markdown
Member

Thanks for the contribution @5eeman! I've incorporated your changes (rebased on current main) into #14 along with ECDH-ES key agreement support. Your fromJson fallback logic is preserved with an additional fix for null-safety in the general JSON serialization path. This PR will be closed when #14 is merged.

@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented Apr 8, 2026

Warning

Rate limit exceeded

@5eeman has exceeded the limit for the number of commits that can be reviewed per hour. Please wait 23 minutes and 31 seconds before requesting another review.

Your organization is not enrolled in usage-based pricing. Contact your admin to enable usage-based pricing to continue reviews beyond the rate limit, or try again in 23 minutes and 31 seconds.

⌛ How to resolve this issue?

After the wait time has elapsed, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout.

Please see our FAQ for further information.

ℹ️ Review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 315c3bf7-2012-4cf3-9c04-a26cdae32122

📥 Commits

Reviewing files that changed from the base of the PR and between a0b51cd and ca7b3b7.

📒 Files selected for processing (4)
  • CHANGELOG.md
  • lib/src/jwe.dart
  • pubspec.yaml
  • test/jwe_test.dart
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants