Made fallback for missing recipients/header.#11
Made fallback for missing recipients/header.#115eeman wants to merge 4 commits intoBdaya-Dev:mainfrom
Conversation
…added protected header; refactor fromJson and add focused tests (fallback, AAD, key wrap, error paths).
|
@ahmednfwela can you review this PR, please? |
|
hi @5eeman sorry for the delay is there a reason to lower the dependency constraints? |
|
Hi! |
ahmednfwela
left a comment
There was a problem hiding this comment.
Thanks for your contribution, LGTM
|
Thanks for the contribution @5eeman! I've incorporated your changes (rebased on current main) into #14 along with ECDH-ES key agreement support. Your fromJson fallback logic is preserved with an additional fix for null-safety in the general JSON serialization path. This PR will be closed when #14 is merged. |
|
Warning Rate limit exceeded
Your organization is not enrolled in usage-based pricing. Contact your admin to enable usage-based pricing to continue reviews beyond the rate limit, or try again in 23 minutes and 31 seconds. ⌛ How to resolve this issue?After the wait time has elapsed, a review can be triggered using the We recommend that you space out your commits to avoid hitting the rate limit. 🚦 How do rate limits work?CodeRabbit enforces hourly rate limits for each developer per organization. Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout. Please see our FAQ for further information. ℹ️ Review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (4)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
No description provided.