Skip to content

fix: sync Cargo.toml workspace version to 0.8.3#393

Merged
toadkicker merged 1 commit intomainfrom
fix/python-sdk-release-0.8.3
May 8, 2026
Merged

fix: sync Cargo.toml workspace version to 0.8.3#393
toadkicker merged 1 commit intomainfrom
fix/python-sdk-release-0.8.3

Conversation

@toadkicker
Copy link
Copy Markdown
Contributor

Summary

  • Update workspace version in Cargo.toml from 0.8.2 to 0.8.3 to match VERSION file

Context

The Python SDK release workflow failed because:

  1. VERSION file was bumped to 0.8.3
  2. But Cargo.toml workspace version remained at 0.8.2
  3. Maturin builds Python wheels using the Cargo.toml version, resulting in pap_protocol-0.8.2-*.whl files
  4. PyPI rejected the upload since 0.8.2 already exists

This fix ensures both version sources are in sync so the next release workflow produces 0.8.3 wheels.

Test plan

  • Version updated in Cargo.toml
  • Merge to main and verify release workflow builds 0.8.3 wheels
  • Confirm PyPI accepts the new version

🤖 Generated with Claude Code

@toadkicker toadkicker merged commit 678bc31 into main May 8, 2026
17 checks passed
@greptile-apps
Copy link
Copy Markdown
Contributor

greptile-apps Bot commented May 8, 2026

Greptile Summary

Syncs the Cargo.toml workspace version from 0.8.2 to 0.8.3 to match the VERSION file, resolving a PyPI upload failure caused by Maturin producing wheels with the stale version.

  • Single-line change to [workspace.package] version in the root Cargo.toml.
  • All 19 member crates and both app packages already use version.workspace = true, so no individual Cargo.toml files need touching — they will all inherit 0.8.3 automatically.

Confidence Score: 5/5

Safe to merge — minimal, targeted version bump with no logic changes.

The change is a single-character version string update. All member crates already use version.workspace = true, so every crate will inherit 0.8.3 without any additional changes. The VERSION file already reads 0.8.3, confirming the two version sources are now in sync. There is no risk of breakage from this change.

No files require special attention.

Important Files Changed

Filename Overview
Cargo.toml Bumps [workspace.package] version from 0.8.2 to 0.8.3 to match the VERSION file; all member crates use version.workspace = true so they will all pick up the new version automatically.

Flowchart

%%{init: {'theme': 'neutral'}}%%
flowchart TD
    A[VERSION file\n0.8.3] -->|"read by release workflow"| B[Release Workflow]
    C[Cargo.toml\nworkspace version] -->|"used by Maturin"| D[Maturin Build]
    D --> E[Python Wheel\npap_protocol-X.Y.Z-*.whl]
    E --> F[PyPI Upload]
    
    subgraph Before Fix
        C1[Cargo.toml v0.8.2] --> D1[Wheel: pap_protocol-0.8.2]
        D1 --> F1["PyPI Rejected\n0.8.2 already exists"]
    end

    subgraph After Fix
        C2[Cargo.toml v0.8.3] --> D2[Wheel: pap_protocol-0.8.3]
        D2 --> F2["PyPI Accepted\nnew version"]
    end
Loading

Reviews (1): Last reviewed commit: "fix: sync Cargo.toml workspace version t..." | Re-trigger Greptile

@github-actions
Copy link
Copy Markdown

github-actions Bot commented May 8, 2026

Benchmark Regression Report

PAP Protocol Benchmark Regression Check
========================================
Baseline: .bench-baseline/baseline.json
Threshold: 55%

  ed25519_keypair_generation                17.3 µs  (baseline: 22.1 µs, -21.6%)  [ok]
  did_key_derivation                         1.4 µs  (baseline: 1.6 µs, -16.7%)  [ok]
  mandate_create_sign                       21.9 µs  (baseline: 26.6 µs, -17.5%)  [ok]
  mandate_chain_verify_depth3              126.9 µs  (baseline: 155.1 µs, -18.1%)  [ok]
  sd_jwt_issue_5claims                      25.1 µs  (baseline: 31.7 µs, -20.5%)  [ok]
  sd_jwt_verify_disclose_3of5               45.0 µs  (baseline: 53.1 µs, -15.2%)  [ok]
  session_open_full_lifecycle               98.1 µs  (baseline: 119.7 µs, -18.0%)  [ok]
  receipt_create_cosign                     44.2 µs  (baseline: 53.4 µs, -17.2%)  [ok]
  federation_announce_local                 55.7 µs  (baseline: 66.9 µs, -16.6%)  [ok]


P99 Tail-Latency Check
----------------------
Results: target/p99_results.json
Threshold: 50%

  session_open_full_lifecycle(p99)         111.5 µs  (baseline: 500.0 µs, -77.7%)  [ok]
  mandate_chain_verify_depth3(p99)         155.3 µs  (baseline: 480.0 µs, -67.6%)  [ok]
  receipt_create_cosign(p99)                49.1 µs  (baseline: 210.0 µs, -76.6%)  [ok]

All benchmarks within 55% of baseline.

Threshold: 10% regression vs baseline from main

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant