Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion VERSION
Original file line number Diff line number Diff line change
@@ -1 +1 @@
0.8.2
0.8.3
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P1 Cargo workspace version not bumped alongside VERSION file

The VERSION file was updated to 0.8.3, but the root Cargo.toml workspace version still reads 0.8.2. Because crates/pap-python/Cargo.toml declares version.workspace = true and pyproject.toml sets version as dynamic, Maturin derives the wheel version directly from the Cargo workspace. The release workflow will tag GitHub as python-v0.8.3 but upload wheels named pap_protocol-0.8.2-*.whl. The subsequent PyPI publish step will then fail with a "File already exists" conflict since 0.8.2 was already released.

Prompt To Fix With AI
This is a comment left during a code review.
Path: VERSION
Line: 1

Comment:
**Cargo workspace version not bumped alongside VERSION file**

The `VERSION` file was updated to `0.8.3`, but the root `Cargo.toml` workspace version still reads `0.8.2`. Because `crates/pap-python/Cargo.toml` declares `version.workspace = true` and `pyproject.toml` sets `version` as `dynamic`, Maturin derives the wheel version directly from the Cargo workspace. The release workflow will tag GitHub as `python-v0.8.3` but upload wheels named `pap_protocol-0.8.2-*.whl`. The subsequent PyPI publish step will then fail with a "File already exists" conflict since 0.8.2 was already released.

How can I resolve this? If you propose a fix, please make it concise.

Fix in Claude Code

5 changes: 5 additions & 0 deletions crates/pap-python/CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,11 @@ All notable changes to the Python SDK will be documented in this file.

## [Unreleased]

## [0.8.3] - 2026-05-08

### Fixed
- CI/CD workflow improvements for wheel building and release publishing

## [0.8.2] - 2026-04-18

### Added
Expand Down
Loading