Address sanitizer/ndk28c #118
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bghgary
reviewed
Nov 4, 2025
matthargett
reviewed
Nov 4, 2025
bghgary
reviewed
Nov 6, 2025
matthargett
reviewed
Nov 8, 2025
matthargett
left a comment
matthargett
left a comment
There was a problem hiding this comment.
one minor question, otherwise looks beautiful! (I'd approve, but I don't have that permission on this repo)
| # Check for Clang since vptr and fdsan are Clang-specific | ||
| if (CMAKE_CXX_COMPILER_ID MATCHES "Clang") | ||
| list(APPEND SANITIZERS "vptr") | ||
| # FDSan only works on Android builds with Clang |
There was a problem hiding this comment.
are we sure it doesn't work with linux (and macOS) as well? is it an issue with clang version in default Ubuntu 24.x and Xcode pre-26? if that's the actual case, can this check be specific about the clang version instead of the OS/platform?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ObjectWrap<T>::ObjectWrap(false positive)