You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
@Arsamat This seems to just be removing some logic (and in doing so the confirm flag will always be true), is this the intended fix? Is there an issue that this is tied to that I could reference?
Yup! This is an issue, there is a logic change with sending emails, its no longer done on the toggle, rather there is a separate button. That logic was making it so we couldn't toggle timeslots for applicants on/off
@vitorvicente Ah so is removing the logic the intended fix? If so, shouldn't this also be modified? (starting on line 185)
let confirm = true;
if (confirm) {
// TODO actually send an email for this
await this.props.firebase.generalSettings().set(settings);
this.setState({ showToast: true, preSaveSettings: settings });
} else {
this.setState({ settings: preSaveSettings });
}
If the swal never pops and confirm is always true we can remove confirm and simplify the if statement to just be the code in the true case. Then we can also remove preSaveSettings from line 160 as it won't be used in this case.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.