Skip to content

Abstract away persistence and cache#92

Draft
dr-orlovsky wants to merge 18 commits into
masterfrom
persistence
Draft

Abstract away persistence and cache#92
dr-orlovsky wants to merge 18 commits into
masterfrom
persistence

Conversation

@dr-orlovsky

Copy link
Copy Markdown
Member

No description provided.

@codecov

codecov Bot commented Jul 2, 2025

Copy link
Copy Markdown

Codecov Report

Attention: Patch coverage is 11.15385% with 231 lines in your changes missing coverage. Please review.

Project coverage is 16.4%. Comparing base (a98b19b) to head (79056c9).

Files with missing lines Patch % Lines
persistence/mem/src/cache.rs 0.0% 137 Missing ⚠️
src/wallet.rs 0.0% 82 Missing ⚠️
src/data.rs 70.7% 12 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff            @@
##           master     #92      +/-   ##
=========================================
+ Coverage     4.7%   16.4%   +11.7%     
=========================================
  Files          24       5      -19     
  Lines        2341     671    -1670     
=========================================
  Hits          110     110              
+ Misses       2231     561    -1670     
Flag Coverage Δ
rust 16.4% <11.2%> (+11.7%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@Crayon-Shin-chan-bitlightlabs

Copy link
Copy Markdown
Contributor

@dr-orlovsky Thank you for the effort you’ve put into this PR.

I think it would be best to abstract register_psbt as well, as a default method in the trait. That way, we can reuse its implementation without needing to worry about details like WalletTx and other internal constructs.

@dr-orlovsky

Copy link
Copy Markdown
Member Author

I think it would be best to abstract register_psbt as well, as a default method in the trait. That way, we can reuse its implementation without needing to worry about details like WalletTx and other internal constructs.

Done. Also did further simplification and enhancements

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants