234 add threading to run parser function #235
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
JosePizarro3
left a comment
JosePizarro3
left a comment
There was a problem hiding this comment.
left some comments
I still want to test out myself, so before merging let me go through it pls
bam_masterdata/cli/run_parser.py
Outdated
| timeout (int, optional): Time in seconds for the parser to complete before timing out. Defaults to 300. | ||
| max_workers (int, optional): Number of threads to use. Defaults to 1. | ||
| """ | ||
| with ThreadPoolExecutor(max_workers) as executor: |
Member
There was a problem hiding this comment.
you should probably add the initial checks that also happen in run_parser(), for consistency.
Alternatively, we could create a class RunParser() with an __init__ accepting the inputs, and two distinct functions: one for running the parser, and another for the threading
Pull Request Test Coverage Report for Build 20276964836Details
💛 - Coveralls |
JosePizarro3
force-pushed
the
234-add-threading-to-run_parser-function
branch
from
dfb60b2 to
ed60b66
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Simple thread function for run_parser
Closes #234