fix(androidctl): rediscover daemon after shutdown race#1
Open
47seek wants to merge 1 commit into
Open
Conversation
Adapt the missing client-side retry from internal commit e1d3e60cf001978c433084ab5c463921e62a34d5. Upstream already contains the androidctld-side active-slot retirement fix, so this only ports the runtime/get rediscovery path and its regression tests.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
androiduseruntime/gethits a shutting-down daemonRUNTIME_BUSYshutdown racesSource
e1d3e60cf001978c433084ab5c463921e62a34d56df2f57d318c29102aae6b4d5c8c6949847fcc8candroidctlclient retry path and testsTesting
.venv/bin/pytest androidctl/tests/unit/test_run_pipeline.py -q.venv/bin/ruff check androidctl/src/androidctl/commands/run_pipeline.py androidctl/tests/unit/test_run_pipeline.py