Skip to content

Conversation

@allenkim0129
Copy link
Contributor

Description

Added test for checking float16 datatype for vector embedding policy.

Since the test can only be ran with Stage account for now, we are skipping the test with @unittest.skip.

Once the backend change is pushed to prod, we will remove the @unittest.skip

All SDK Contribution checklist:

  • The pull request does not introduce [breaking changes]
  • CHANGELOG is updated for new features, bug fixes or other significant changes.
  • I have read the contribution guidelines.

General Guidelines and Best Practices

  • Title of the pull request is clear and informative.
  • There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For more information on cleaning up the commits in your PR, see this page.

Testing Guidelines

  • Pull request includes test coverage for the included changes.

@Copilot Copilot AI review requested due to automatic review settings October 23, 2025 18:14
@allenkim0129 allenkim0129 requested a review from a team as a code owner October 23, 2025 18:14
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR adds test coverage for the float16 data type in vector embedding policies. The main change is adding a new parameterized test that validates all supported vector embedding data types (float32, float16, int8, uint8), and updating an existing negative test case.

Key changes:

  • Added comprehensive test for valid vector embedding data types
  • Updated existing negative test to use a valid data type (float16) instead of invalid one (float33)

Copy link
Member

@aayush3011 aayush3011 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

Status: No status

Development

Successfully merging this pull request may close these issues.

2 participants