Skip to content

Conversation

@scbedd
Copy link
Member

@scbedd scbedd commented Oct 23, 2025

Usable without needing to stumble over selection of uv or pip given the context. It figures all that out for the user.

todo:

@scbedd scbedd self-assigned this Oct 23, 2025
@Copilot Copilot AI review requested due to automatic review settings October 23, 2025 00:21
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR refactors the pip freeze debugging functionality by consolidating it into a reusable pip_freeze method in the Check base class. The method handles both uv and pip environments automatically, eliminating code duplication across multiple check implementations.

Key changes:

  • Added a centralized pip_freeze method to Check.py that detects and handles both uv and pip package managers
  • Replaced duplicated pip freeze implementations in pylint.py and bandit.py with calls to the new method
  • Updated pylint.py to use run_venv_command instead of check_call for better error handling

Reviewed Changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated 3 comments.

File Description
eng/tools/azure-sdk-tools/azpysdk/Check.py Added new pip_freeze method to base class that handles both uv and pip environments
eng/tools/azure-sdk-tools/azpysdk/pylint.py Replaced inline pip freeze code with call to new pip_freeze method; refactored pylint execution for better error handling
eng/tools/azure-sdk-tools/azpysdk/bandit.py Replaced inline pip freeze code with call to new pip_freeze method
eng/tools/azure-sdk-tools/azpysdk/import_all.py Removed outdated comment about pip freeze command

@scbedd scbedd requested a review from a team as a code owner October 23, 2025 01:07
@scbedd scbedd moved this from 🤔 Triage to 🔬 Dev in PR in Azure SDK EngSys 🍔🌭 Oct 23, 2025
@scbedd scbedd requested a review from Copilot October 24, 2025 23:08
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

Copilot reviewed 10 out of 11 changed files in this pull request and generated 4 comments.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: 🔬 Dev in PR

Development

Successfully merging this pull request may close these issues.

2 participants