[Storage] Decompression for Binary Response in Download APIs #43587
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
weirongw23-msft
requested review from
annatisch,
jalauzon-msft and
vincenttran-msft
as code owners
There was a problem hiding this comment.
Pull Request Overview
This PR adds support for automatic decompression of compressed blob content during download operations in the Azure Storage Blob SDK. The feature allows users to control whether compressed content (e.g., gzip) should be automatically decompressed by passing a decompress parameter to the download_blob method.
Key Changes:
- Added a new optional
decompressparameter to thedownload_blobmethod in both sync and async blob clients - Modified the download implementation to handle the
decompressparameter correctly when encryption is used - Added comprehensive tests for both sync and async scenarios to verify decompression behavior
Reviewed Changes
Copilot reviewed 8 out of 8 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
azure/storage/blob/_blob_client.py |
Added documentation for the new decompress parameter in the sync blob client |
azure/storage/blob/_blob_client.pyi |
Added type hints for the decompress parameter across all download_blob overloads in sync client |
azure/storage/blob/_download.py |
Modified to preserve the decompress parameter during encryption data requests in sync implementation |
azure/storage/blob/aio/_blob_client_async.py |
Added documentation for the new decompress parameter in the async blob client |
azure/storage/blob/aio/_blob_client_async.pyi |
Added type hints for the decompress parameter across all download_blob overloads in async client |
azure/storage/blob/aio/_download_async.py |
Modified to preserve the decompress parameter during encryption data requests in async implementation |
tests/test_common_blob.py |
Added test case to verify decompression behavior in sync client |
tests/test_common_blob_async.py |
Added test case to verify decompression behavior in async client |
sdk/storage/azure-storage-blob/azure/storage/blob/_blob_client.py
Outdated
Show resolved
Hide resolved
sdk/storage/azure-storage-blob/azure/storage/blob/aio/_blob_client_async.py
Outdated
Show resolved
Hide resolved
API Change CheckAPIView identified API level changes in this PR and created the following API reviews |
|
/azp run python - storage - tests |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.