[Storage] Added support for timezone awareness datetime objects in FileProperties
#43566
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
weirongw23-msft
requested review from
annatisch,
jalauzon-msft and
vincenttran-msft
as code owners
There was a problem hiding this comment.
Pull Request Overview
This PR adds timezone awareness to datetime objects in FileProperties by ensuring all parsed datetime values are converted to UTC timezone when they lack timezone information.
Key Changes:
- Import
timezonefrom datetime module - Add timezone awareness check and UTC conversion to
_parse_datetime_from_strfunction
| us = int(us[:-2]) # microseconds | ||
| datetime_obj = dt + timedelta(microseconds=us) | ||
| if not datetime_obj.tzinfo: | ||
| datetime_obj = datetime_obj.astimezone(timezone.utc) |
There was a problem hiding this comment.
Calling astimezone() on a naive datetime object (one without tzinfo) will raise a ValueError. Use datetime_obj.replace(tzinfo=timezone.utc) instead to set UTC timezone on naive datetime objects.
Suggested change
| datetime_obj = datetime_obj.astimezone(timezone.utc) | |
| datetime_obj = datetime_obj.replace(tzinfo=timezone.utc) |
weirongw23-msft
changed the title
datetimeobjects in FilePropertiesdatetime objects in FileProperties
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For
last_modified, this is already adatetimeobject from the service with no microseconds supplied andtimezoneis defaulted to UTC. However, forchange_time,creation_time,last_write_timefrom the service is returned as a string object, to be parsed into datetime, and is assumed to be UTC. This PR ensures consistency across all the fields and make alldatetimeobjects timezone aware.