[Storage] Added Support for UseDevelopmentStorage=true; for Connection String Client Constructors
#43565
Conversation
weirongw23-msft
requested review from
annatisch,
jalauzon-msft and
vincenttran-msft
as code owners
There was a problem hiding this comment.
Pull Request Overview
This PR adds support for the UseDevelopmentStorage=true; connection string format across Azure Storage client constructors, enabling developers to easily connect to local development storage emulators (like Azurite). The implementation follows the Azure Storage emulator's standard configuration by automatically configuring the appropriate endpoints, credentials, and protocol settings when this connection string format is detected.
Key Changes:
- Added connection string parsing logic to detect and handle
UseDevelopmentStorage=true - Implemented hardcoded development storage credentials and endpoints matching Azure Storage Emulator defaults
- Added comprehensive test coverage for the new development storage connection string feature
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| sdk/storage/azure-storage-blob/azure/storage/blob/_shared/base_client.py | Implements _parse_development_storage() function with emulator defaults and adds detection logic in parse_connection_str() |
| sdk/storage/azure-storage-blob/tests/test_blob_client.py | Adds test case validating development storage connection string parsing and client initialization |
sdk/storage/azure-storage-blob/azure/storage/blob/_shared/base_client.py
Outdated
Show resolved
Hide resolved
| if any(len(tup) != 2 for tup in conn_settings_list): | ||
| raise ValueError("Connection string is either blank or malformed.") | ||
| conn_settings = dict((key.upper(), val) for key, val in conn_settings_list) | ||
| if conn_settings.get('USEDEVELOPMENTSTORAGE') == 'true': |
There was a problem hiding this comment.
The comparison should be case-insensitive for the value. Consider using .lower() == 'true' to handle connection strings like UseDevelopmentStorage=True; or UseDevelopmentStorage=TRUE; which may be valid variations.
| if conn_settings.get('USEDEVELOPMENTSTORAGE') == 'true': | |
| if conn_settings.get('USEDEVELOPMENTSTORAGE', '').lower() == 'true': |
There was a problem hiding this comment.
Should we support case insensitivity?
There was a problem hiding this comment.
Line 423 already uppercase all the keys, so we don't have to worry about case sensitivity again
|
The current failures are due to a circular import error. It is likely the case that we cannot put these constants in |
1 participant
No description provided.