[EventHubs] Replacing scaling logs to WebJobs extension methods #53925
+9
−6
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alrod
requested review from
a team,
ArthurMa1978,
axisc,
hmlam,
jorgerangel-msft,
jsquire and
sjkwak
as code owners
Copilot finished reviewing on behalf of
alrod
November 14, 2025 00:20
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR replaces custom scaling logs with WebJobs extension methods to standardize logging for EventHubs scaling operations.
- Refactored logging in EventHubsTargetScaler to use
LogFunctionScaleVoteextension method - Updated error logging in EventHubMetricsProvider to use
LogFunctionScaleErrorextension method - Removed redundant try-catch blocks that were previously used only for logging warnings
- Updated Microsoft.Azure.WebJobs package dependencies to version 3.0.42-dev to enable the new logging extension methods
Reviewed Changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| EventHubsTargetScaler.cs | Consolidated two separate log statements into a single LogFunctionScaleVote call with concatenated details string |
| EventHubMetricsProvider.cs | Replaced LogWarning with LogFunctionScaleError and removed try-catch blocks that only logged warnings without handling exceptions |
| Packages.Data.props | Updated Microsoft.Azure.WebJobs packages to version 3.0.42-dev to support new logging extension methods |
| NuGet.Config | Added local package source for development/testing purposes |
...enthub/Microsoft.Azure.WebJobs.Extensions.EventHubs/src/Listeners/EventHubMetricsProvider.cs
Outdated
Show resolved
Hide resolved
...enthub/Microsoft.Azure.WebJobs.Extensions.EventHubs/src/Listeners/EventHubMetricsProvider.cs
Outdated
Show resolved
Hide resolved
mathewc
reviewed
Nov 14, 2025
...enthub/Microsoft.Azure.WebJobs.Extensions.EventHubs/src/Listeners/EventHubMetricsProvider.cs
Show resolved
Hide resolved
alrod
force-pushed
the
alrod/replace-logs-eh
branch
2 times, most recently
from
076ca2a to
be2e16a
Compare
alrod
force-pushed
the
alrod/replace-logs-eh
branch
from
be2e16a to
729774e
Compare
mathewc
approved these changes
Nov 18, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Contributing to the Azure SDK
Please see our CONTRIBUTING.md if you are not familiar with contributing to this repository or have questions.
For specific information about pull request etiquette and best practices, see this section.