MPG migration - databasewatcher #53913
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Pull Request Overview
This pull request implements an MPG (Management Plane Generator) migration for the databasewatcher SDK. The migration updates the code generation approach from the legacy generator to the new Azure Management Generator.
Key changes:
- Updates
tsp-location.yamlto reference the new management emitter package - Refactors REST operations classes from high-level API methods to low-level protocol methods
- Introduces new pagination helper classes for collection results
- Updates serialization patterns and model properties naming conventions
- Changes from
stringsubscription IDs toGuidtype - Modernizes code generation patterns across models and operations
Reviewed Changes
Copilot reviewed 7 out of 128 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| tsp-location.yaml | Adds emitter package reference for management plane generator |
| WatchersRestOperations.cs | Refactored from full REST operations to protocol-level HTTP message builders |
| TargetsRestOperations.cs | Same refactoring pattern as WatchersRestOperations |
| SharedPrivateLinkResourcesRestOperations.cs | Same refactoring pattern as WatchersRestOperations |
| HealthValidationsRestOperations.cs | Same refactoring pattern as WatchersRestOperations |
| AlertRuleResourcesRestOperations.cs | Same refactoring pattern as WatchersRestOperations |
| *CollectionResultOfT.cs (new files) | New pagination helper classes for sync and async operations |
| Models/*.cs | Updated serialization, property naming, and constructor patterns |
| ProviderConstants.cs | Made partial and added XML documentation |
| Utf8JsonRequestContent.cs | Made partial and added XML documentation |
| AzureResourceManagerDatabaseWatcherContext.cs | Updated documentation link format |
API Change CheckAPIView identified API level changes in this PR and created the following API reviews |
haiyuazhang
force-pushed
the
haiyzhan/databasewatcher
branch
from
9df4a9d to
291e993
Compare
live1206
reviewed
Nov 17, 2025
Member
live1206
left a comment
live1206
left a comment
There was a problem hiding this comment.
could you update inventory.md?
live1206
approved these changes
Nov 17, 2025
haiyuazhang
force-pushed
the
haiyzhan/databasewatcher
branch
from
9c8847d to
7a661f9
Compare
live1206
approved these changes
Nov 18, 2025
ArthurMa1978
approved these changes
Nov 18, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
MPG migration - databasewatcher: #53873