Skip to content

Conversation

@amih90
Copy link
Contributor

@amih90 amih90 commented Dec 3, 2025

ARM (Control Plane) API Specification Update Pull Request

Tip

Overwhelmed by all this guidance? See the Getting help section at the bottom of this PR description.

PR review workflow diagram

Please understand this diagram before proceeding. It explains how to get your PR approved & merged.

spec_pr_review_workflow_diagram

Purpose of this PR

What's the purpose of this PR? Check the specific option that applies. This is mandatory!

  • New resource provider.
  • New API version for an existing resource provider. (If API spec is not defined in TypeSpec, the PR should have been created in adherence to OpenAPI specs PR creation guidance).
  • Update existing version for a new feature. (This is applicable only when you are revising a private preview API version.)
  • Update existing version to fix OpenAPI spec quality issues in S360.
  • Convert existing OpenAPI spec to TypeSpec spec (do not combine this with implementing changes for a new API version).
  • Other, please clarify:
    • edit this with your clarification

Due diligence checklist

To merge this PR, you must go through the following checklist and confirm you understood
and followed the instructions by checking all the boxes:

  • I confirm this PR is modifying Azure Resource Manager (ARM) related specifications, and not data plane related specifications.
  • I have reviewed following Resource Provider guidelines, including
    ARM resource provider contract and
    REST guidelines (estimated time: 4 hours).
    I understand this is required before I can proceed to the diagram Step 2, "ARM API changes review", for this PR.
  • A release plan has been created. If not, please create one as it will help guide you through the REST API and SDK creation process.

Additional information

Viewing API changes

For convenient view of the API changes made by this PR, refer to the URLs provided in the table
in the Generated ApiView comment added to this PR. You can use ApiView to show API versions diff.

Suppressing failures

If one or multiple validation error/warning suppression(s) is detected in your PR, please follow the
suppressions guide to get approval.

Getting help

  • First, please carefully read through this PR description, from top to bottom. Please fill out the Purpose of this PR and Due diligence checklist.
  • If you don't have permissions to remove or add labels to the PR, request write access per aka.ms/azsdk/access#request-access-to-rest-api-or-sdk-repositories
  • To understand what you must do next to merge this PR, see the Next Steps to Merge comment. It will appear within few minutes of submitting this PR and will continue to be up-to-date with current PR state.
  • For guidance on fixing this PR CI check failures, see the hyperlinks provided in given failure
    and https://aka.ms/ci-fix.
  • For help with ARM review (PR workflow diagram Step 2), see https://aka.ms/azsdk/pr-arm-review.
  • If the PR CI checks appear to be stuck in queued state, please add a comment with contents /azp run.
    This should result in a new comment denoting a PR validation pipeline has started and the checks should be updated after few minutes.
  • If the help provided by the previous points is not enough, post to https://aka.ms/azsdk/support/specreview-channel and link to this PR.
  • For guidance on SDK breaking change review, refer to https://aka.ms/ci-fix.

@github-actions
Copy link

github-actions bot commented Dec 3, 2025

Next Steps to Merge

✅ All automated merging requirements have been met! To get your PR merged, see aka.ms/azsdk/specreview/merge.

Comment generated by summarize-checks workflow run.

@amih90 amih90 changed the title Ami/35421676 microsoft.security stable api 35421676 microsoft.security stable api Dec 3, 2025
@amih90 amih90 changed the title 35421676 microsoft.security stable api microsoft.security/privateLinks stable api 2026-01-01 Dec 3, 2025
@github-actions github-actions bot added brownfield Brownfield services will soon be required to convert to TypeSpec. See https://aka.ms/azsdk/typespec. ARMReview new-api-version resource-manager WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required labels Dec 3, 2025
@github-actions
Copy link

github-actions bot commented Dec 3, 2025

API Change Check

APIView identified API level changes in this PR and created the following API reviews

Language API Review for Package
Swagger common
Go sdk/resourcemanager/security/armsecurity
Java com.azure.resourcemanager:azure-resourcemanager-security
JavaScript @azure/arm-security
Python azure-mgmt-security

@eliagrady
Copy link
Member

remove

  • Microsoft.Security/preview/2025-09-01-preview/privateLinks.json from package compositev3 and add yours

@amih90
Copy link
Contributor Author

amih90 commented Dec 3, 2025

remove

  • Microsoft.Security/preview/2025-09-01-preview/privateLinks.json from package compositev3 and add yours

It raised Avocado MULTIPLE_API_VERSION: "The default tag contains multiple API versions swaggers."

@psah434
Copy link
Member

psah434 commented Dec 3, 2025

fix avocado errors

@psah434 psah434 added ARMChangesRequested and removed WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required labels Dec 3, 2025
@amih90
Copy link
Contributor Author

amih90 commented Dec 4, 2025

fix avocado errors

@psah434
I would request Avocado exception similar to #35777 (comment) by
gary-x-li added the Approved-Avocado label on Jul 22
from the same reason "Unfortunately, the Microsoft.Security resource provider cannot meet Avocado’s requirements due to its use of composite API versioning. As a result, we’re currently unable to fulfill this request."

@github-actions github-actions bot added the WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required label Dec 4, 2025
@psah434 psah434 added the ARMSignedOff <valid label in PR review process>add this label when ARM approve updates after review label Dec 4, 2025
@github-actions github-actions bot removed the WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required label Dec 4, 2025
@psah434 psah434 added WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required Approved-Avocado and removed WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required labels Dec 4, 2025
@amih90 amih90 enabled auto-merge (squash) December 5, 2025 13:40
@eliagrady eliagrady self-assigned this Dec 5, 2025
@eliagrady eliagrady self-requested a review December 7, 2025 08:54
Copy link
Member

@eliagrady eliagrady left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

approved

@amih90 amih90 added the PublishToCustomers Acknowledgement the changes will be published to Azure customers. label Dec 7, 2025
@amih90 amih90 merged commit 92131fd into main Dec 7, 2025
48 of 50 checks passed
@amih90 amih90 deleted the ami/35421676-microsoft.security-stable-api branch December 7, 2025 09:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Approved-Avocado ARMReview ARMSignedOff <valid label in PR review process>add this label when ARM approve updates after review brownfield Brownfield services will soon be required to convert to TypeSpec. See https://aka.ms/azsdk/typespec. new-api-version PublishToCustomers Acknowledgement the changes will be published to Azure customers. resource-manager

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants