northeastus5: add secondary region pairing for northeastus5 #28649
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Thanks for your contribution! The pull request validation has started. Please revisit this comment for updated status. |
There was a problem hiding this comment.
Pull Request Overview
Adds cross region restore (CRR) support for the new Azure region northeastus5 by updating the internal region pairing map and documenting the change in the RecoveryServices changelog.
- Added region pairing entry for northeastus5 -> centralus in BackupUtils.
- Documented the new CRR support in ChangeLog.md.
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| src/RecoveryServices/RecoveryServices/ChangeLog.md | Added release note entry for northeastus5 CRR support. |
| src/RecoveryServices/RecoveryServices.Backup/Helpers/BackupUtils.cs | Added northeastus5 mapping to cross-region pairing dictionary. |
| {"southcentralus2", "westcentralus"}, | ||
| {"southeastus3", "westus3"}, | ||
| {"eastus3", "westus3"}, | ||
| {"northeastus5", "centralus"}, |
There was a problem hiding this comment.
A new region mapping was added without an accompanying test update; please add or extend a unit test that validates the CRR pairing includes northeastus5 -> centralus (similar to existing tests for other regions) to prevent regressions and ensure future refactors don't drop this entry.
Copilot generated this review using guidance from repository custom instructions.
|
/azp run |
|
Azure Pipelines successfully started running 3 pipeline(s). |
|
/azp run |
|
Azure Pipelines successfully started running 3 pipeline(s). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add CRR support for upcoming region northeastus5
Mandatory Checklist
Please choose the target release of Azure PowerShell. (⚠️ Target release is a different concept from API readiness. Please click below links for details.)
Check this box to confirm: I have read the Submitting Changes section of
CONTRIBUTING.mdand reviewed the following information:ChangeLog.mdfile(s) appropriatelysrc/{{SERVICE}}/{{SERVICE}}/ChangeLog.md.## Upcoming Releaseheader in the past tense.ChangeLog.mdif no new release is required, such as fixing test case only.I am following this guidelines