update Az.AksArc tests and fix commands #28645
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Thanks for your contribution! The pull request validation has started. Please revisit this comment for updated status. |
|
/azp run |
|
Azure Pipelines successfully started running 3 pipeline(s). |
There was a problem hiding this comment.
Pull Request Overview
This PR adds comprehensive tests for the Az.AksArc PowerShell module and fixes various command parameter set configurations. The changes include creating extensive test coverage for cluster management operations, improving parameter organization, and correcting documentation to ensure proper command functionality.
- Extensive test suite implementation with live-only tests for cluster and nodepool operations
- Parameter set restructuring and validation fixes for Update/New/Remove commands
- Documentation corrections and help file updates for improved clarity
Reviewed Changes
Copilot reviewed 68 out of 73 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
src/AksArc/AksArc/help/*.md |
Updates command help documentation with corrected parameter sets and descriptions |
src/AksArc/AksArc/ChangeLog.md |
Documents fixes and test additions for version 0.2.4 |
src/AksArc/AksArc/Az.AksArc.psd1 |
Updates module dependencies and configuration settings |
src/AksArc/AksArc.Autorest/test/*.ps1 |
Adds comprehensive test coverage for all AksArc commands |
src/AksArc/AksArc.Autorest/test/utils.ps1 |
Implements test environment setup with cluster creation |
TheOnlyWei
force-pushed
the
improve-aksarc-test-coverage
branch
from
4127fdd to
108b404
Compare
TheOnlyWei
force-pushed
the
improve-aksarc-test-coverage
branch
from
108b404 to
617e476
Compare
isra-fel
reviewed
Oct 10, 2025
|
/azp run |
|
Azure Pipelines successfully started running 3 pipeline(s). |
|
This PR was labeled "needs-revision" because it has unresolved review comments or CI failures. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Added tests and fixed some commands. See
AksArc/AksArc/ChangeLog.md.Mandatory Checklist
Please choose the target release of Azure PowerShell. (⚠️ Target release is a different concept from API readiness. Please click below links for details.)
Check this box to confirm: I have read the Submitting Changes section of
CONTRIBUTING.mdand reviewed the following information:ChangeLog.mdfile(s) appropriatelysrc/{{SERVICE}}/{{SERVICE}}/ChangeLog.md.## Upcoming Releaseheader in the past tense.ChangeLog.mdif no new release is required, such as fixing test case only.Got this error: