Skip to content

Conversation

@Ajsalemo
Copy link

This PR is to update the help info for az containerapp sessionpool create when using a container type of "CustomContainer". For the help docs in this PR, it may not be clear to users that --image expects the fully qualified image name.

Currently in the docs, --image is shown as accepting a value of MyImage, which may imply just literally the image name only.

Since through some testing (and external reports) it expects the fully qualified name (myregistry.something.com/image:tag), this PR is to reflect that


This checklist is used to make sure that common guidelines for a pull request are followed.

Related command

az containerapp sessionpool create

(full command that is wanting to be updated)

az containerapp sessionpool create -n mysessionpool -g MyResourceGroup \ --container-type CustomContainer --environment MyEnvironment --image myregistry.azurecr.io/MyImage:Tag \ --cpu 0.5 --memory 1Gi --target-port 80 --registry-server myregistry.azurecr.io \ --registry-username myregistry --registry-password $REGISTRY_PASSWORD \ --location eastasia
From: Microsoft Learn | az containerapp sessionpool create

General Guidelines

  • Have you run azdev style <YOUR_EXT> locally? (pip install azdev required)
  • Have you run python scripts/ci/test_index.py -q locally? (pip install wheel==0.30.0 required)
  • My extension version conforms to the Extension version schema

For new extensions:

About Extension Publish

There is a pipeline to automatically build, upload and publish extension wheels.
Once your pull request is merged into main branch, a new pull request will be created to update src/index.json automatically.
You only need to update the version information in file setup.py and historical information in file HISTORY.rst in your PR but do not modify src/index.json.

Copilot AI review requested due to automatic review settings November 17, 2025 15:21
@azure-client-tools-bot-prd
Copy link

Validation for Breaking Change Starting...

Thanks for your contribution!

@azure-client-tools-bot-prd
Copy link

Hi @Ajsalemo,
Please write the description of changes which can be perceived by customers into HISTORY.rst.
If you want to release a new extension version, please update the version in setup.py as well.

@yonzhan
Copy link
Collaborator

yonzhan commented Nov 17, 2025

Thank you for your contribution! We will review the pull request and get back to you soon.

@github-actions
Copy link

The git hooks are available for azure-cli and azure-cli-extensions repos. They could help you run required checks before creating the PR.

Please sync the latest code with latest dev branch (for azure-cli) or main branch (for azure-cli-extensions).
After that please run the following commands to enable git hooks:

pip install azdev --upgrade
azdev setup -c <your azure-cli repo path> -r <your azure-cli-extensions repo path>

@microsoft-github-policy-service
Copy link
Contributor

Thank you for your contribution @Ajsalemo! We will review the pull request and get back to you soon.

@microsoft-github-policy-service microsoft-github-policy-service bot added the Auto-Assign Auto assign by bot label Nov 17, 2025
@github-actions
Copy link

CodeGen Tools Feedback Collection

Thank you for using our CodeGen tool. We value your feedback, and we would like to know how we can improve our product. Please take a few minutes to fill our codegen survey

@github-actions
Copy link

Hi @Ajsalemo

Release Suggestions

Module: containerapp

  • Please log updates into to src/containerapp/HISTORY.rst
  • Update VERSION to 1.3.0b2 in src/containerapp/setup.py

Notes

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR updates the help documentation for the az containerapp sessionpool create command to clarify that the --image parameter expects a fully qualified image name rather than just an image name.

  • Updated four example commands to use myregistry.azurecr.io/MyImage:Tag instead of MyImage

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Auto-Assign Auto assign by bot ContainerApp customer-reported Issues that are reported by GitHub users external to the Azure organization.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants